From dbfa26b74b1ae9c8d3cd65949401f8abcf4ae046 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Tue, 14 Mar 2017 16:13:16 -0700 Subject: [PATCH 1/3] Fix typo in README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0aa26720d3..d7d773ab95 100644 --- a/README.md +++ b/README.md @@ -73,7 +73,7 @@ Uses a Firebase Storage trigger. ### [Post GitHub commits to Slack channel](/github-to-slack) -Demonstrates hows how to automatically post GitHub commits to a Slack channel using an HTTPS triggered Function. +Demonstrates how to automatically post GitHub commits to a Slack channel using an HTTPS triggered Function. ### [Automatically Moderate Images](/moderate-images) From dc5e2e5bf1ab3e2d4c550d639e5b640773bbcf0a Mon Sep 17 00:00:00 2001 From: James Daniels Date: Tue, 14 Mar 2017 16:14:56 -0700 Subject: [PATCH 2/3] Dropped Assistant callouts --- github-to-slack/README.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/github-to-slack/README.md b/github-to-slack/README.md index 85e452d990..79bf852c08 100644 --- a/github-to-slack/README.md +++ b/github-to-slack/README.md @@ -11,14 +11,12 @@ Further reading: See file [functions/index.js](functions/index.js) for the code. -Handling the Google Actions requests is done using the [Google Actions SDK](https://www.npmjs.com/package/actions-on-google). - The dependencies are listed in [functions/package.json](functions/package.json). ## Deploy and test -To test this sample action: +To test this integration: - Create a Firebase Project using the [Firebase Developer Console](https://console.firebase.google.com) - Enable billing on your project by switching to the Blaze or Flame plan. See [pricing](https://firebase.google.com/pricing/) for more details. This is required to be able to do requests to non-Google services. @@ -34,5 +32,4 @@ To test this sample action: firebase functions:config:set slack.webhook_url="https://hooks.slack.com/services/..." github.secret="A_SECRET_YOU_DEFINED_WHEN_SETTING_UP_THE_GITHUB_WEBHOOK" ``` - Deploy your project using `firebase deploy` - - Make your action available for testing using the `gactions preview action.json` - - Test your Action on the [Google Home Web Simulator](https://g.co/actionswebsim) by saying "Talk to My Action" + - Push a commit to your GitHub repo From b86dd1fda092451f235e608188b47363f5773507 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Tue, 14 Mar 2017 16:21:50 -0700 Subject: [PATCH 3/3] Adding npm install instructions --- github-to-slack/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/github-to-slack/README.md b/github-to-slack/README.md index 79bf852c08..848592dfe2 100644 --- a/github-to-slack/README.md +++ b/github-to-slack/README.md @@ -21,6 +21,7 @@ To test this integration: - Create a Firebase Project using the [Firebase Developer Console](https://console.firebase.google.com) - Enable billing on your project by switching to the Blaze or Flame plan. See [pricing](https://firebase.google.com/pricing/) for more details. This is required to be able to do requests to non-Google services. - Configure this sample to use your project using `firebase --use add` and select your project. + - Install dependencies locally by running: `cd functions; npm install; cd -` - [Add a WebHook to your GitHub repo](https://help.github.com/articles/about-webhooks/) with the following settings: - Payload URL: `https://us-central1-.cloudfunctions.net/githubWebhook` - Content type: `application/json`