fix(go/ai): genkit ignores dotprompt-defined roles #3780
Merged
+109
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
josearomeroj
force-pushed
the
fix_load_role_dotprompt_parts
branch
from
b19d47f to
ea17dd1
Compare
hugoaguirre
reviewed
Nov 11, 2025
Contributor
hugoaguirre
left a comment
hugoaguirre
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Overall, LGTM 👍🏽
rutujaD1999
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Genkit's prompt load to respect role definitions from dotprompt files instead of forcing all messages to use the "user" role.
#3711
Checklist (if applicable):