This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Throw in tests when getting onGeoQueryError. #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
commented
Dec 22, 2017
| @@ -74,7 +74,6 @@ public void onGeoQueryReady() { | |||
|
|
|||
| @Override | |||
| public void onGeoQueryError(DatabaseError error) { | |||
|
|
|||
| throw error.toException(); | |||
There was a problem hiding this comment.
I've noticed that this is using 2 spaces which is part of the Java Google Style Guide. I also prefer 2 spaces. Should we change it everywhere or was this a mistake?
There was a problem hiding this comment.
Was probably a mistake, I prefer 4 spaces but was using a new version of IntelliJ I had not set up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #101