Allow cocoapods install of Firebase + Geofire for Swift #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,7 +28,8 @@ | |||
|
|
|||
| #import <Foundation/Foundation.h> | |||
| #import <CoreLocation/CoreLocation.h> | |||
| #import <Firebase/Firebase.h> | |||
|
|
|||
| typedef NSUInteger FirebaseHandle; | |||
There was a problem hiding this comment.
I don't really like the redefinition here, but I guess that's what you get when do you weird stuff like using typedefs...
|
I can merge as is, however I'm a bit surprised that you can do something like including a library in multiple dependencies in Swift. I'm assuming this has something to do with the fact that Firebase is marked as project-level and not public (see [1]). I wonder if there is a way to let CocoaPods know that it should be marked public... |
jdimond
added a commit
that referenced
this pull request
May 21, 2015
Allow cocoapods install of Firebase + Geofire for Swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out Swift threw some compiler errors because we included Firebase/Firebase.h in public header files. Moved them into .m files which makes Swift happy.
@jdimond