From 7c826980da4ac5aa901e257e81f2c41a1ef89d78 Mon Sep 17 00:00:00 2001 From: Frieder Bluemle Date: Wed, 29 Jun 2016 23:46:51 +0800 Subject: [PATCH 1/5] Fix colorAccent on API < 21 --- .../app/src/main/res/values-v21/styles.xml | 24 +++++++++++++++++++ analytics/app/src/main/res/values/styles.xml | 1 - 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 analytics/app/src/main/res/values-v21/styles.xml diff --git a/analytics/app/src/main/res/values-v21/styles.xml b/analytics/app/src/main/res/values-v21/styles.xml new file mode 100644 index 0000000000..33bf15f817 --- /dev/null +++ b/analytics/app/src/main/res/values-v21/styles.xml @@ -0,0 +1,24 @@ + + + + + + + diff --git a/analytics/app/src/main/res/values/styles.xml b/analytics/app/src/main/res/values/styles.xml index 33bf15f817..6e72511135 100644 --- a/analytics/app/src/main/res/values/styles.xml +++ b/analytics/app/src/main/res/values/styles.xml @@ -18,7 +18,6 @@ specific language governing permissions and limitations under the License. From 2b324f4f8beb1cecc16cfe7b2b72d870732ec0b8 Mon Sep 17 00:00:00 2001 From: Frieder Bluemle Date: Wed, 29 Jun 2016 23:47:26 +0800 Subject: [PATCH 2/5] Fix Facebook dependencies used in main source set The dependencies from the Facebook SDK are now cleanly isolated in a new AndroidManifest.xml under the facebook source set. It will be merged with the main manifest at compile time. --- auth/app/src/facebook/AndroidManifest.xml | 16 ++++++++++++++++ .../res/layout/activity_facebook.xml | 0 auth/app/src/main/AndroidManifest.xml | 11 ----------- 3 files changed, 16 insertions(+), 11 deletions(-) create mode 100644 auth/app/src/facebook/AndroidManifest.xml rename auth/app/src/{main => facebook}/res/layout/activity_facebook.xml (100%) diff --git a/auth/app/src/facebook/AndroidManifest.xml b/auth/app/src/facebook/AndroidManifest.xml new file mode 100644 index 0000000000..12d4203fd4 --- /dev/null +++ b/auth/app/src/facebook/AndroidManifest.xml @@ -0,0 +1,16 @@ + + + + + + + + + diff --git a/auth/app/src/main/res/layout/activity_facebook.xml b/auth/app/src/facebook/res/layout/activity_facebook.xml similarity index 100% rename from auth/app/src/main/res/layout/activity_facebook.xml rename to auth/app/src/facebook/res/layout/activity_facebook.xml diff --git a/auth/app/src/main/AndroidManifest.xml b/auth/app/src/main/AndroidManifest.xml index 5aaf4b3061..1e6420c938 100644 --- a/auth/app/src/main/AndroidManifest.xml +++ b/auth/app/src/main/AndroidManifest.xml @@ -27,17 +27,6 @@ - - - - - Date: Thu, 30 Jun 2016 00:08:14 +0800 Subject: [PATCH 3/5] Fix Travis CI build --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index e33a84b270..3dc9cc413b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,10 +3,10 @@ jdk: - oraclejdk8 android: components: - - platform-tools - tools - build-tools-24.0.0 - android-24 + - platform-tools - extra-google-google_play_services - extra-google-m2repository - extra-android-m2repository From fb6bdb4b97ff13ec8cb5c9af47e7e50fe55b73e8 Mon Sep 17 00:00:00 2001 From: Frieder Bluemle Date: Wed, 29 Jun 2016 15:56:14 +0800 Subject: [PATCH 4/5] Revert "Fix App Indexing build" This reverts commit 89461c8406e74536aa3face4dfa06ce1733f52ff. --- app-indexing/app/build.gradle | 5 ----- 1 file changed, 5 deletions(-) diff --git a/app-indexing/app/build.gradle b/app-indexing/app/build.gradle index 6c3a3de52d..6c4ba35d45 100644 --- a/app-indexing/app/build.gradle +++ b/app-indexing/app/build.gradle @@ -13,17 +13,12 @@ android { testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner" } - buildTypes { release { minifyEnabled true proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' } } - - lintOptions { - abortOnError false - } } dependencies { From bafe78c9dc28e6abdd674cc95ac358145cbc3a85 Mon Sep 17 00:00:00 2001 From: Frieder Bluemle Date: Wed, 29 Jun 2016 16:23:14 +0800 Subject: [PATCH 5/5] Do not ignore Lint errors --- admob/app/build.gradle | 4 ---- analytics/app/build.gradle | 4 ---- auth/app/build.gradle | 4 ---- config/app/build.gradle | 4 ---- crash/app/build.gradle | 4 ---- database/app/build.gradle | 4 ---- dynamiclinks/app/build.gradle | 4 ---- invites/app/build.gradle | 4 ---- messaging/app/build.gradle | 4 ---- storage/app/build.gradle | 4 ---- 10 files changed, 40 deletions(-) diff --git a/admob/app/build.gradle b/admob/app/build.gradle index f777db4abb..e21f110bba 100644 --- a/admob/app/build.gradle +++ b/admob/app/build.gradle @@ -21,10 +21,6 @@ android { } } - lintOptions { - abortOnError false - } - packagingOptions { exclude 'LICENSE.txt' } diff --git a/analytics/app/build.gradle b/analytics/app/build.gradle index 13775ceaf4..4fae803fe2 100644 --- a/analytics/app/build.gradle +++ b/analytics/app/build.gradle @@ -12,10 +12,6 @@ android { versionName "1.0" } - lintOptions { - abortOnError false - } - buildTypes { release { minifyEnabled true diff --git a/auth/app/build.gradle b/auth/app/build.gradle index 3ba0a52ce3..8b27632bf0 100644 --- a/auth/app/build.gradle +++ b/auth/app/build.gradle @@ -19,10 +19,6 @@ android { } } - lintOptions { - abortOnError false - } - productFlavors { // Build variant to include the Facebook Android SDk diff --git a/config/app/build.gradle b/config/app/build.gradle index a0648ff4e0..34a1ed6b64 100644 --- a/config/app/build.gradle +++ b/config/app/build.gradle @@ -12,10 +12,6 @@ android { versionName "1.0" } - lintOptions { - abortOnError false - } - buildTypes { release { minifyEnabled true diff --git a/crash/app/build.gradle b/crash/app/build.gradle index 12ea113979..0453b55aa3 100644 --- a/crash/app/build.gradle +++ b/crash/app/build.gradle @@ -12,10 +12,6 @@ android { versionName "1.0" } - lintOptions { - abortOnError false - } - buildTypes { release { minifyEnabled true diff --git a/database/app/build.gradle b/database/app/build.gradle index 8c05485962..d062b7b1e3 100644 --- a/database/app/build.gradle +++ b/database/app/build.gradle @@ -12,10 +12,6 @@ android { versionName "1.0" } - lintOptions { - abortOnError false - } - buildTypes { release { minifyEnabled true diff --git a/dynamiclinks/app/build.gradle b/dynamiclinks/app/build.gradle index 6a0bfcdbd0..49ce2884d4 100644 --- a/dynamiclinks/app/build.gradle +++ b/dynamiclinks/app/build.gradle @@ -12,10 +12,6 @@ android { versionName "1.0" } - lintOptions { - abortOnError false - } - buildTypes { release { minifyEnabled true diff --git a/invites/app/build.gradle b/invites/app/build.gradle index e7e8bb5a1d..bd4ba5902e 100644 --- a/invites/app/build.gradle +++ b/invites/app/build.gradle @@ -21,10 +21,6 @@ android { } } - lintOptions { - abortOnError false - } - packagingOptions { exclude 'LICENSE.txt' } diff --git a/messaging/app/build.gradle b/messaging/app/build.gradle index a62e1d6156..8d4ab30ee0 100644 --- a/messaging/app/build.gradle +++ b/messaging/app/build.gradle @@ -21,10 +21,6 @@ android { } } - lintOptions { - abortOnError false - } - packagingOptions { exclude 'LICENSE.txt' } diff --git a/storage/app/build.gradle b/storage/app/build.gradle index 288597972c..73942a303f 100644 --- a/storage/app/build.gradle +++ b/storage/app/build.gradle @@ -12,10 +12,6 @@ android { versionName "1.0" } - lintOptions { - abortOnError false - } - buildTypes { release { minifyEnabled true