Skip to content

Conversation

@lazars14-f
Copy link
Collaborator

@lazars14-f lazars14-f commented Jan 14, 2025

Pull Request Description

Contains the following changes:

  • scope property for both asset and blockchain apis was changed to uppercase (Global => GLOBAL)
  • verified property was removed from the asset response dto
  • displayName and displaySymbol in asset-response was changed to be a required property in the asset-response

Fixes (link to the issue here)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore / Documentation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • I have added corresponding labels to the PR

@lazars14-f lazars14-f added the documentation Improvements or additions to documentation label Jan 14, 2025
@lazars14-f lazars14-f requested a review from SlavaSereb January 14, 2025 08:02
@lazars14-f lazars14-f self-assigned this Jan 14, 2025
@lazars14-f lazars14-f marked this pull request as ready for review March 24, 2025 12:25
@lazars14-f lazars14-f merged commit af90162 into fireblocks:master Mar 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants