ResourceMgr: Move methods to models

[eg-firebolt]

• clean up logging (do not log exceptions by default for security/privacy)
• refactor models
  • https://packboard.atlassian.net/browse/FIR-8023
  • https://packboard.atlassian.net/browse/FIR-8024

[eg-firebolt]

In https://packboard.atlassian.net/browse/FIR-8023, you asked for a method named list. I tried to use this in a few places, but one in particular tripped up the tests. For some reason, it thinks the type hint is the function.

An easy workaround is simply to use List[Engine] instead of list[engine] as the typehint.

But I wonder if we should stay away from using list as a method name all together given that there is a built-in list() method in python.

EDIT: we decided to use get_many instead of list. This also will be less of an issue once we add support for 3.7+

[stepansergeevitch]

nit: _engine_service, _database_service -> _service and move this method to FireboltBaseModel

[eg-firebolt]

I tried moving to FireboltBaseModel, but its not so easy to make this generic, because when you call self._service.get(..) we don't know if we are talking getting an engine or a database or something else.

I am going to leave this mostly as-is for now. We can look at it together at some point.

[stepansergeevitch]

What will happen if engine is already started? Would it error if you try to start it again?

[eg-firebolt]

It does not seem to cause an error, just tested it:

[stepansergeevitch]

could we simply pass a dictionary here?
why do we need a _DatabaseCreateRequest?

[eg-firebolt]

I could do a dictionary instead, we don't need a _DatabaseCreateRequest, however, I kind of like it because it's explicit about types that are expected in the request and whether or not they are optional. It also prevents me from having to call .jsonable_dict in multiple places.

This becomes a bit more useful in the engine case than the database case. Here's what it would probably look like as a dict in the engine case:

        response = self.client.post(
            url="/core/v1/account/engines",
            headers={"Content-type": "application/json"},
            json=prune_dict(
                dict(
                    account_id=self.account_id,
                    engine=engine.jsonable_dict(by_alias=True),
                    engine_revision=engine_revision.jsonable_dict(by_alias=True) if engine_revision else None
                )
            )
        )

All that being said, if you like the dict way a lot more, I can take out the helper models

[stepansergeevitch]

General comment: This PR came out to be pretty big, I would ask to split such PRs into smaller ones in future. This way it would be easier to understand/review them. For example, this one could be splitted by changes for each instance type