Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 29, 2025

chore(NoTicket): remove enable_create_table_with_struct_type setting

Summary

Removed the SET enable_create_table_with_struct_type=true; statement from the setup_struct_query test fixture in tests/integration/dbapi/conftest.py. According to the requester, this setting is no longer needed and the CREATE TABLE statements with struct types work correctly without it.

Review & Testing Checklist for Human

  • Verify struct integration tests pass: The removed setting was part of the setup_struct_query fixture used by struct-related tests. Ensure all tests using this fixture still pass in CI.
  • Manual verification (optional): If possible, manually test creating tables with struct types without this setting to confirm it's truly obsolete.

Notes

  • This change was found by searching all 6 specified repositories (firebolt-python-sdk, firebolt-go-sdk, firebolt-rust-sdk, firebolt-sqlalchemy, dbt-firebolt, firebolt-fivetran-connector). Only firebolt-python-sdk had any references to this setting.
  • The pre-commit hooks passed successfully, but I have not run the actual integration tests that depend on this fixture.
  • The change is very targeted - only one line removed from a test setup query.

Devin run: https://app.devin.ai/sessions/347340519e744009b0f0ee6746ef57eb
Requested by: petro.tiurin@firebolt.io (@ptiurin)

Co-Authored-By: petro.tiurin@firebolt.io <petro.tiurin@firebolt.io>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner October 29, 2025 10:18
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@sonarqubecloud
Copy link

@ptiurin ptiurin merged commit 0a85eaa into main Oct 29, 2025
15 checks passed
@ptiurin ptiurin deleted the devin/1761732879-remove-enable-create-table-with-struct-type branch October 29, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants