feat: migrate from asyncio to trio #88
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
reviewed
Dec 29, 2021
Contributor
ptiurin
left a comment
ptiurin
left a comment
There was a problem hiding this comment.
As far as migration goes, this seems to be pretty seamless so lgtm.
However, I'm wary about moving to a different async library. Asyncio is an industry standard with many usecases tested daily, while trio looks like a fairly recent one. We'll be losing a lot in terms of support - asyncio has 5000+ questions on Stack Overflow, while trio has 59.
Is "Event loop closed" error a known issue in asyncio? If not, can we create a reproducer and raise an issue on their repo to see what the maintainers say?
| + (HttpxAsyncClient.__doc__ or "") | ||
| """ | ||
|
|
||
| @async_cached_property |
Contributor
There was a problem hiding this comment.
Any reason account_id is no longer a property?
Contributor
Author
|
Closing since I've figured out a much more elegant solution, which allows us to still use asyncio. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to migrate from using asyncio as async backend to trio.
It seems like asyncio has a bug, which causes tcp transport to raise "Event loop closed" error on close in some cases.
Trio, on the other hand, seems not to have this issue