From a14ac736c26a957cb2962f0280cc131a0650fbf8 Mon Sep 17 00:00:00 2001 From: ptiurin Date: Wed, 24 May 2023 11:01:22 +0100 Subject: [PATCH 1/2] fix: Close method on async --- src/firebolt_db/firebolt_async_dialect.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/firebolt_db/firebolt_async_dialect.py b/src/firebolt_db/firebolt_async_dialect.py index 8ceeca0..9ca2bf2 100644 --- a/src/firebolt_db/firebolt_async_dialect.py +++ b/src/firebolt_db/firebolt_async_dialect.py @@ -126,7 +126,7 @@ def commit(self) -> None: self._connection.commit() def close(self) -> None: - self.await_(self._connection._aclose()) + self.await_(self._connection.aclose()) class AsyncAPIWrapper(ModuleType): From 36518a5bd6ee7e67e743fb52c6786f9107e76a3b Mon Sep 17 00:00:00 2001 From: ptiurin Date: Wed, 24 May 2023 11:03:36 +0100 Subject: [PATCH 2/2] fix tests --- tests/unit/test_firebolt_async_dialect.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/test_firebolt_async_dialect.py b/tests/unit/test_firebolt_async_dialect.py index d6a49cb..977976d 100644 --- a/tests/unit/test_firebolt_async_dialect.py +++ b/tests/unit/test_firebolt_async_dialect.py @@ -58,7 +58,7 @@ def test_connection() -> AsyncConnectionWrapper: wrapper = await greenlet_spawn(test_connection) assert isinstance(wrapper.cursor(), AsyncCursorWrapper) async_api.connect.return_value.commit.assert_called_once() - async_api.connect.return_value._aclose.assert_awaited_once() + async_api.connect.return_value.aclose.assert_awaited_once() @pytest.mark.asyncio async def test_cursor_execute(