Skip to content

Commit

Permalink
Another improvement to issue 5834
Browse files Browse the repository at this point in the history
  • Loading branch information
SebastianZ committed Aug 24, 2012
1 parent 3965dd0 commit 11a249f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 16 deletions.
19 changes: 4 additions & 15 deletions extension/content/firebug/cookies/cookieReps.js
Expand Up @@ -935,32 +935,21 @@ CookieReps.SizeInfoTip = domplate(Firebug.Rep,
TABLE({"class": "sizeInfoTip", "id": "cookiesSizeInfoTip", role:"presentation"},
TBODY(
FOR("size", "$sizeInfo",
TAG("$size|getRowTag", {size: "$size"})
TAG("$size|sizeTag", {size: "$size"})
)
)
),

sizeTag:
TR({"class": "sizeInfoRow", $collapsed: "$size|hideRow"},
TR({"class": "sizeInfoRow"},
TD({"class": "sizeInfoLabelCol"}, "$size.label"),
TD({"class": "sizeInfoSizeCol"}, "$size|formatSize"),
TD({"class": "sizeInfoDetailCol"}, "$size|formatNumber")
),

getRowTag: function(size)
{
return (size.label == "-") ? this.separatorTag : this.sizeTag;
},

hideRow: function(size)
{
return size.size < 0;
},

formatSize: function(size)
{
size = Str.formatSize(size.size);
return size;
return Str.formatSize(size.size);
},

formatNumber: function(size)
Expand All @@ -977,7 +966,7 @@ CookieReps.SizeInfoTip = domplate(Firebug.Rep,
sizeInfo.push({label: Locale.$STR("cookie.sizeinfo.Size"), size: size});

if (size != rawSize)
sizeInfo.push({label: Locale.$STR("cookie.sizeinfo.RawSize"), size: rawSize});
sizeInfo.push({label: Locale.$STR("cookie.sizeinfo.Raw_Size"), size: rawSize});

this.tag.replace({sizeInfo: sizeInfo}, parentNode);
},
Expand Down
2 changes: 1 addition & 1 deletion extension/locale/en-US/cookies.properties
Expand Up @@ -318,4 +318,4 @@ cookies.console.Filter_By_Cookies=Filter By Cookies
firebug.shortcut.removeAllCookies.label=Remove All Cookies

cookie.sizeinfo.Size=Size
cookie.sizeinfo.RawSize=Raw Size
cookie.sizeinfo.Raw_Size=Raw Size

0 comments on commit 11a249f

Please sign in to comment.