Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Issue 6316: Improve usability of long (and wide) stack traces

  • Loading branch information...
commit 50240f123f236e2ea583de38e17af743053fb61c 1 parent 68f4214
Jan Odvarko janodvarko authored
19 extension/content/firebug/debugger/stack/callstackPanel.js
View
@@ -14,9 +14,10 @@ define([
"firebug/chrome/menu",
"firebug/debugger/stack/stackFrameRep",
"firebug/debugger/stack/stackTrace",
+ "firebug/lib/options",
],
function(Obj, Firebug, FBTrace, FirebugReps, Events, Wrapper, StackFrame, Css, Arr, Dom, Menu,
- StackFrameRep, StackTrace) {
+ StackFrameRep, StackTrace, Options) {
// ********************************************************************************************* //
// Constants
@@ -209,6 +210,10 @@ CallstackPanel.prototype = Obj.extend(Firebug.Panel,
Css.setClass(this.panelNode, "objectBox-stackTrace");
+ // Update visibility of stack frame arguments.
+ var name = "showStackFrameArguments";
+ this.updateOption(name, Options.get(name));
+
if (trace && trace.frames.length != 0)
{
var rep = Firebug.getRep(trace, this.context);
@@ -261,9 +266,9 @@ CallstackPanel.prototype = Obj.extend(Firebug.Panel,
"callstack.option.tip.Omit_Object_Path_Stack"));
// Show/hide stack frame arguments.
- items.push(Menu.optionMenu("callstack.option.Hide_Arguments",
- "hideStackFrameArguments",
- "callstack.option.tip.Hide_Arguments"));
+ items.push(Menu.optionMenu("callstack.option.Show_Arguments",
+ "showStackFrameArguments",
+ "callstack.option.tip.Show_Arguments"));
return items;
},
@@ -299,12 +304,12 @@ CallstackPanel.prototype = Obj.extend(Firebug.Panel,
updateOption: function(name, value)
{
- if (name == "hideStackFrameArguments")
+ if (name == "showStackFrameArguments")
{
if (value)
- Css.setClass(this.panelNode, "hideArguments");
- else
Css.removeClass(this.panelNode, "hideArguments");
+ else
+ Css.setClass(this.panelNode, "hideArguments");
}
},
});
2  extension/defaults/preferences/firebug.js
View
@@ -100,7 +100,7 @@ pref("extensions.firebug.breakOnExceptions", false);
// Stack
pref("extensions.firebug.omitObjectPathStack", false);
-pref("extensions.firebug.hideStackFrameArguments", false);
+pref("extensions.firebug.showStackFrameArguments", true);
// DOM
pref("extensions.firebug.showUserProps", true);
8 extension/locale/en-US/firebug.properties
View
@@ -983,11 +983,11 @@ OmitObjectPathStack=Omit Toolbar Stack
callstack.option.tip.Omit_Object_Path_Stack=Do not display the object path stack
Load_Original_Source=Load Original Source
css.tip.Load_Original_Source=Discard the changes and load the original CSS
-# LOCALIZATION NOTE (callstack.option.Hide_Arguments, callstack.option.tip.Hide_Arguments):
+# LOCALIZATION NOTE (callstack.option.Show_Arguments, callstack.option.tip.Show_Arguments):
# Stack side panel option (located in tab's option menu). If set to true,
-# function arguments are not displayed
-callstack.option.Hide_Arguments=Hide Arguments
-callstack.option.tip.Hide_Arguments=Do not display function arguments
+# function arguments are displayed
+callstack.option.Show_Arguments=Show Arguments
+callstack.option.tip.Show_Arguments=Display also function arguments
# LOCALIZATION NOTE (Copy_Rule_Declaration, css.tip.Copy_Rule_Declaration):
# Menu item label and tooltip used in CSS panel/Style side panel context menu.
# Allows copying the current CSS rule including all its properties to the clipboard.
4 extension/skin/classic/callstack.css
View
@@ -62,10 +62,10 @@
}
/**
- * The one-line list of arguments is hidden if the frame is exapanded. So, the source
+ * The one-line list of arguments is hidden if the frame is expanded. So, the source
* link is nicely visible.
* There is also an option that allows to hide the argument list by default
- * (see extensions.firebug.hideStackFrameArguments).
+ * (see extensions.firebug.showStackFrameArguments).
*/
.objectBox-stackFrame.opened .arguments,
.panelNode-callstack.hideArguments .objectBox-stackFrame .arguments {
Please sign in to comment.
Something went wrong with that request. Please try again.