Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Issue 5474: Firebug + Devtools = spurious web dev console errors

  • Loading branch information...
commit 8e3fdb8188ebfae875ff82531dca8319f71500eb 1 parent eae2759
Jan Odvarko janodvarko authored
2  extension/content/firebug/accessible/a11y.js
@@ -1278,7 +1278,7 @@ Firebug.A11yModel = Obj.extend(Firebug.Module,
1278 1278 case Node.ATTRIBUTE_NODE:
1279 1279 elem = node.ownerElement;
1280 1280 matchFeedback += Locale.$STRF("a11y.updates.match found in attribute",
1281   - [match.match[0], node.nodeName, node.nodeValue, elem.nodeName,
  1281 + [match.match[0], node.name, node.value, elem.nodeName,
1282 1282 Xpath.getElementTreeXPath(elem)]);
1283 1283 break;
1284 1284
8 extension/content/firebug/chrome/reps.js
@@ -834,7 +834,7 @@ FirebugReps.Element = domplate(Firebug.Rep,
834 834 getAttrValue: function(attr)
835 835 {
836 836 var limit = Firebug.displayedAttributeValueLimit;
837   - return (limit > 0) ? Str.cropString(attr.nodeValue, limit) : attr.nodeValue;
  837 + return (limit > 0) ? Str.cropString(attr.value, limit) : attr.value;
838 838 },
839 839
840 840 getVisible: function(elt)
@@ -2905,18 +2905,18 @@ FirebugReps.Attr = domplate(Firebug.Rep,
2905 2905 SPAN(
2906 2906 SPAN({"class": "attrTitle"}, "$object|getTitle"),
2907 2907 SPAN({"class": "attrEqual"}, "="),
2908   - TAG("$object|getValueTag", {object: "$object.nodeValue"})
  2908 + TAG("$object|getValueTag", {object: "$object.value"})
2909 2909 )
2910 2910 ),
2911 2911
2912 2912 getTitle: function(attr)
2913 2913 {
2914   - return attr.nodeName;
  2914 + return attr.name;
2915 2915 },
2916 2916
2917 2917 getValueTag: function(object)
2918 2918 {
2919   - return Firebug.getRep(object.nodeValue).tag;
  2919 + return Firebug.getRep(object.value).tag;
2920 2920 },
2921 2921
2922 2922 // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //
3  extension/content/firebug/html/htmlLib.js
@@ -202,7 +202,7 @@ var HTMLLib =
202 202 var nodeBox = ioBox.openToObject(node.ownerElement);
203 203 if (nodeBox)
204 204 {
205   - var attrNodeBox = HTMLLib.findNodeAttrBox(nodeBox, node.nodeName);
  205 + var attrNodeBox = HTMLLib.findNodeAttrBox(nodeBox, node.name);
206 206 return Dom.getChildByClass(attrNodeBox, isValue ? "nodeValue" : "nodeName");
207 207 }
208 208 }
@@ -703,6 +703,7 @@ var HTMLLib =
703 703 {
704 704 if (node instanceof window.HTMLAppletElement)
705 705 return false;
  706 +
706 707 return node.nodeType == window.Node.TEXT_NODE && Str.isWhitespace(node.nodeValue);
707 708 },
708 709
2  extension/content/firebug/html/htmlPanel.js
@@ -1724,7 +1724,7 @@ Firebug.HTMLPanel.prototype = Obj.extend(WalkingPanel,
1724 1724
1725 1725 var AttrTag = Firebug.HTMLPanel.AttrTag =
1726 1726 SPAN({"class": "nodeAttr editGroup"},
1727   - " ", SPAN({"class": "nodeName editable"}, "$attr.nodeName"), "="",
  1727 + " ", SPAN({"class": "nodeName editable"}, "$attr.name"), "="",
1728 1728 SPAN({"class": "nodeValue editable"}, "$attr|getAttrValue"), """
1729 1729 );
1730 1730

0 comments on commit 8e3fdb8

Please sign in to comment.
Something went wrong with that request. Please try again.