Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Issue 5826: Fonts are not displayed inside Style side panel

  • Loading branch information...
commit ab3bed9bfb3f4de1782eb86bf76eb14faec76474 1 parent 6500237
@simonlindholm simonlindholm authored
Showing with 8 additions and 4 deletions.
  1. +8 −4 extension/content/firebug/css/stylePanel.js
View
12 extension/content/firebug/css/stylePanel.js
@@ -95,12 +95,12 @@ CSSStylePanel.prototype = Obj.extend(CSSStyleSheetPanel.prototype,
getSeparator: function(part)
{
- if (part.type == "otherProps")
- return " ";
-
if (part.lastFont || part.type == "important")
return "";
+ if (part.type == "otherProps")
+ return " ";
+
return ",";
},
@@ -827,7 +827,11 @@ function getFontPropValueParts(element, value, propName)
);
var matches = rePreFont.exec(value);
if (!matches)
- return;
+ {
+ // Non-simple font value, like "inherit", "status-bar" or
+ // "-moz-calc(12px) Arial" - just return the whole text.
@SebastianZ Owner

AFAICS you can't set "-moz-calc(12px) Arial" in a "font" property.

@simonlindholm Owner

Indeed - http://code.google.com/p/fbug/issues/detail?id=5603#c5. But it could be fixed and become a non-working case syntactically distinct from the other ones, so I mentioned it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ return [{type: "otherProps", value: value, lastFont: true}];
+ }
var preProps = matches[0].slice(0, -1);
parts.push({type: "otherProps", value: preProps});
value = value.substr(matches[0].length);

0 comments on commit ab3bed9

Please sign in to comment.
Something went wrong with that request. Please try again.