Permalink
Browse files

Apply some of the safe changes of c1e97f9

  • Loading branch information...
1 parent 53cccbe commit c81e8c3f51517bc8e03f8261859db399352bb6a3 @simonlindholm simonlindholm committed Dec 22, 2012
Showing with 12 additions and 4 deletions.
  1. +1 −1 extension/content/firebug/firebugOverlay.xul
  2. +11 −3 extension/content/firebug/html/inspector.js
@@ -21,7 +21,7 @@
<tooltip id="fbTooltip" class="fbURLMenuItem"
onpopupshowing="return Firebug.chrome.onTooltipShowing(event);"/>
- <panel id="fbQuickInfoPanel" width="210" noautohide="true" noautofocus="true"
+ <panel id="fbQuickInfoPanel" width="210" noautofocus="true"
onmousedown="Firebug.Inspector.quickInfoBoxHandler(event);"
onmouseover="Firebug.Inspector.quickInfoBoxHandler(event);"
onmouseout="Firebug.Inspector.quickInfoBoxHandler(event);">
@@ -1089,11 +1089,19 @@ var quickInfoBox =
if (qiBox.state==="closed")
{
- qiBox.hidePopup();
-
this.storedX = this.storedX || Firefox.getElementById("content").tabContainer.boxObject.screenX + 5;
this.storedY = this.storedY || Firefox.getElementById("content").tabContainer.boxObject.screenY + 35;
+ // Dynamically set noautohide to avoid mozilla bug 545265.
+ if (!this.noautohideAdded)
+ {
+ this.noautohideAdded = true;
+ qiBox.addEventListener("popupshowing", function runOnce()
+ {
+ qiBox.removeEventListener("popupshowing", runOnce, false);
+ qiBox.setAttribute("noautohide", true);
+ }, false);
+ }
qiBox.openPopupAtScreen(this.storedX, this.storedY, false);
}
@@ -1226,7 +1234,7 @@ var quickInfoBox =
lab.setAttribute("class", "fbQuickInfoName");
lab.setAttribute("value", attribs[i]);
hbox.appendChild(lab);
- var desc = document.createElement("description");
+ var desc = document.createElement("label");
desc.setAttribute("class", "fbQuickInfoValue");
desc.appendChild(document.createTextNode(": " + value));
hbox.appendChild(desc);

0 comments on commit c81e8c3

Please sign in to comment.