Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Issue 5869 (Parts of headers wrapped in arrow brackets are treated as…

  • Loading branch information...
commit e9b10d7da4a446c944156523027a8cfac9a3355a 1 parent 6950b50
@SebastianZ SebastianZ authored
Showing with 1 addition and 0 deletions.
  1. +1 −0  extension/content/firebug/net/netReps.js
View
1  extension/content/firebug/net/netReps.js
@@ -1646,6 +1646,7 @@ Firebug.NetMonitor.NetInfoHeaders = domplate(Firebug.Rep, new Firebug.Listener()
else
{
var source = requestHeaders ? file.requestHeadersText : file.responseHeadersText;
+ source = source.replace("<", "&lt;", "g").replace(">", "&gt;", "g");
this.insertSource(netInfoBox, source, target.rowName);
target.innerHTML = Locale.$STR("net.headers.pretty print");
}

2 comments on commit e9b10d7

@simonlindholm

Can't you change insertSource to set .textContent instead? (Otherwise, we have functions for this in lib/string which also correctly escape "&".)

@SebastianZ
Owner

As always you're the master of clean code. :-)
Did both in 2a3f4bd.
Thanks for the hint.

Sebastian

Please sign in to comment.
Something went wrong with that request. Please try again.