Permalink
Browse files

the side effected bug- Opening editor but empty when attribute name i…

…s clicked- is fixed
  • Loading branch information...
1 parent e85aea1 commit f109552818672e5a017ecf22a6bf02a2f7c54565 @farshidbeheshti farshidbeheshti committed with SebastianZ Aug 9, 2012
Showing with 3,578 additions and 3,575 deletions.
  1. +7 −4 extension/content/firebug/html/htmlPanel.js
  2. +7 −7 extension/locale/en-US/firebug-amo.properties
  3. +99 −99 extension/locale/en-US/firebug-tracing.properties
  4. +1,664 −1,664 extension/locale/en-US/firebug.properties
  5. +13 −13 extension/skin/classic/migrationArrow.svg
  6. +29 −29 tests/content/commandLine/5130/issue5130.html
  7. +22 −22 tests/content/commandLine/5130/issue5130.js
  8. +46 −46 tests/content/console/2271/issue2271.html
  9. +34 −34 tests/content/console/3042/issue3042.html
  10. +38 −38 tests/content/console/3042/issue3042.js
  11. +31 −31 tests/content/cookies/general/cookiesPanel.html
  12. +14 −14 tests/content/css/2967/issue2967.js
  13. +53 −53 tests/content/css/2967/issue2967.xml
  14. +54 −54 tests/content/css/3303/issue3303.html
  15. +71 −71 tests/content/css/3303/issue3303.js
  16. +50 −50 tests/content/css/5438/issue5438.html
  17. +44 −44 tests/content/css/5438/issue5438.js
  18. +41 −41 tests/content/css/5461/issue5461.html
  19. +42 −42 tests/content/css/5461/issue5461.js
  20. +33 −33 tests/content/css/computed/5451/issue5451.html
  21. +20 −20 tests/content/css/computed/5451/issue5451.js
  22. +2 −2 tests/content/dom/5247/external/externalStylesheet.css
  23. +86 −86 tests/content/dom/5247/issue5247.html
  24. +75 −75 tests/content/dom/5247/issue5247.js
  25. +33 −33 tests/content/firebug/5349/issue5349.html
  26. +13 −13 tests/content/firebug/5349/issue5349.js
  27. +40 −40 tests/content/html/3296/issue3296.html
  28. +29 −29 tests/content/html/3296/issue3296.js
  29. +30 −30 tests/content/net/4805/issue4805.html
  30. +40 −40 tests/content/net/4805/issue4805.js
  31. +33 −33 tests/content/script/4724/issue4724.html
  32. +59 −59 tests/content/script/4724/issue4724.js
  33. +68 −68 tests/templates/default/issueXXXX.html
  34. +25 −25 tests/templates/default/issueXXXX.js
  35. +85 −85 tests/templates/default/issueXXXXSeveralCases.html
  36. +48 −48 tests/templates/default/issueXXXXSeveralCases.js
  37. +142 −142 tests/templates/default/testcase.css
  38. +61 −61 tests/templates/firebugLite/issueXXXX.html
  39. +180 −180 tests/templates/firebugLite/testcase.css
  40. +84 −84 tests/templates/net/issueXXXX.html
  41. +30 −30 tests/templates/net/issueXXXX.js
  42. +3 −3 tests/templates/net/issueXXXX.php
@@ -2268,14 +2268,17 @@ AttributeEditor.prototype = domplate(Firebug.InlineEditor.prototype,
{
if (value == "")
return value;
-
var element = Firebug.getRepObject(target);
if (element && element instanceof window.Element)
{
- var attributeName = Dom.getPreviousByClass(target, "nodeName").textContent;
- return element.getAttribute(attributeName);
+ // If object that was clicked to edit was
+ // attribute value, not attribute name.
+ if (Css.hasClass(target, "nodeValue"))
+ {
+ var attributeName = Dom.getPreviousByClass(target, "nodeName").textContent;
+ return element.getAttribute(attributeName);
+ }
}
-
return value;
}
});
@@ -1,7 +1,7 @@
-# LOCALIZATION NOTE (firebug.amo.summary, firebug.amo.description, firebug.amo.developer.comments):
-# These texts are used on Mozilla Add-on site: https://addons.mozilla.org/en-US/firefox/addon/1843
-# They are not direct part of Firebug extension and so, you can't see them in Firebug's UI.
-# Note that firebug.amo.summary must not exceed 250 characters (limitation by AMO site)
-firebug.amo.summary1.6=Firebug integrates with Firefox to put a wealth of development tools at your fingertips while you browse. You can edit, debug, and monitor CSS, HTML, and JavaScript live in any web page...\n\nFirebug 1.6 requires Firefox 3.6 or higher.
-firebug.amo.description=Firebug integrates with Firefox to put a wealth of development tools at your fingertips while you browse. You can edit, debug, and monitor CSS, HTML, and JavaScript live in any web page.\n\nVisit the Firebug website for documentation, screen shots, and discussion forums: http://getfirebug.com
-firebug.amo.developer.comments=If you have any problems, please read the FireBug FAQ.\n\nhttp://getfirebug.com/faq.html
+# LOCALIZATION NOTE (firebug.amo.summary, firebug.amo.description, firebug.amo.developer.comments):
+# These texts are used on Mozilla Add-on site: https://addons.mozilla.org/en-US/firefox/addon/1843
+# They are not direct part of Firebug extension and so, you can't see them in Firebug's UI.
+# Note that firebug.amo.summary must not exceed 250 characters (limitation by AMO site)
+firebug.amo.summary1.6=Firebug integrates with Firefox to put a wealth of development tools at your fingertips while you browse. You can edit, debug, and monitor CSS, HTML, and JavaScript live in any web page...\n\nFirebug 1.6 requires Firefox 3.6 or higher.
+firebug.amo.description=Firebug integrates with Firefox to put a wealth of development tools at your fingertips while you browse. You can edit, debug, and monitor CSS, HTML, and JavaScript live in any web page.\n\nVisit the Firebug website for documentation, screen shots, and discussion forums: http://getfirebug.com
+firebug.amo.developer.comments=If you have any problems, please read the FireBug FAQ.\n\nhttp://getfirebug.com/faq.html
@@ -1,100 +1,100 @@
-# LOCALIZATION NOTE (Open_Firebug_Tracing, Always_Open_Firebug_Tracing):
-# Firebug tracing console menu items (located in Firebug's menu).
-Open_Firebug_Tracing=Open Firebug Tracing
-Always_Open_Firebug_Tracing=Always Open Firebug Tracing
-
-# LOCALIZATION NOTE (title.Tracing): Title for Firebug tracing console window (verb).
-title.Tracing=Tracing
-
-tracing.Show_Scope_Variables=Show Scope Variables
-tracing.Show_Time=Show Time
-tracing.tab.Stack=Stack
-tracing.tab.Exception=Exception
-tracing.tab.Properties=Properties
-tracing.tab.Scope=Scope
-tracing.tab.Response=Response
-tracing.tab.Source=Source
-tracing.tab.Interfaces=Interfaces
-tracing.tab.Object=Object
-tracing.tab.Event=Event
-tracing.cmd.Clear=Clear
-tracing.cmd.tip.Clear=Remove All Messages
-tracing.cmd.Find=Find
-tracing.cmd.tip.Find=Find Text
-tracing.cmd.Bookmark=Bookmark
-tracing.cmd.tip.Bookmark=Insert Bookmark
-tracing.cmd.Restart=Restart Firefox
-tracing.cmd.tip.Restart=Restart Firefox
-tracing.cmd.Exit=Exit Firefox
-tracing.cmd.tip.Exit=Exit Firefox
-tracing.cmd.Save=Save to File
-tracing.cmd.tip.Save=Save logs into a file
-tracing.cmd.Load=Load from File
-tracing.cmd.tip.Load=Load logs from a file
-tracing.cmd.Expand_All=Expand All
-tracing.cmd.Collapse_All=Collapse All
-tracing.cmd.Tools=Tools
-tracing.cmd.tip.Tools=Tools
-tracing.cmd.Clear_Browser_Cache=Clear Browser Cache
-tracing.cmd.tip.Clear_Browser_Cache=Clear Browser Cache
-tracing.cmd.Force_Garbage_Collector=Force Garbage Collector
-tracing.cmd.tip.Force_Garbage_Collector=Force Garbage Collector
-tracing.cmd.Open_Profile_Directory=Open Profile Directory
-tracing.cmd.tip.Open_Profile_Directory=Open Profile Directory
-tracing.option.A11Y_Description=Accessibility issues
-tracing.option.ACTIVATION_Description=Firebug activation
-tracing.option.ACTIVITYOBSERVER_Description=Firebug activity observer
-tracing.option.ANNOTATIONS_Description=Firebug website annotation
-tracing.option.BP_Description=Breakpoints
-tracing.option.CACHE_Description=Source cache
-tracing.option.COMMANDLINE_Description=Command Line & Command Line Popup
-tracing.option.COMPILATION_UNITS_Description=Script compilation units
-tracing.option.CONSOLE_Description=Console Panel
-tracing.option.CSS_Description=CSS parsing
-
-tracing.option.DISPATCH_Description=Event dispatching
-tracing.option.DOM_Description=DOM
-tracing.option.DOMPLATE_Description=Domplate creation
-tracing.option.EDITOR_Description=Inline Editor & Autocompleter
-tracing.option.ERRORLOG_Description=Error log of JS, CSS, XML etc.
-tracing.option.ERRORS_Description=Internal Firebug errors
-tracing.option.EVAL_Description=Script evaluation
-tracing.option.FBS_BP_Description=Firebug service breakpoints
-tracing.option.FBS_CREATION_Description=Firebug service script creation
-tracing.option.FBS_ERRORS_Description=Firebug service errors
-
-tracing.option.FBS_FINDDEBUGGER_Description=Firebug service find debugger
-
-tracing.option.FBS_FUNCTION_Description=Firebug service function
-tracing.option.FBS_JSDCONTEXT_Description=Firebug service JavaScript Debugger context
-tracing.option.FBS_SRCUNITS_Description=Firebug service source units
-tracing.option.FBS_STEP_Description=Firebug service JavaScript Debugger stepping
-tracing.option.FBS_TRACKFILES_Description=Firebug service tracked files
-tracing.option.FUNCTION_NAMES_Description=JavaScript function names
-tracing.option.HISTORY_Description=Firebug Navigation History
-tracing.option.HTML_Description=HTML
-tracing.option.HTTPOBSERVER_Description=HTTP request observer
-tracing.option.INFOTIP_Description=Infotip
-tracing.option.INITIALIZE_Description=Firebug initialization
-tracing.option.INSPECT_Description=Inspector
-tracing.option.JSONVIEWER_Description=JSON viewer
-tracing.option.LINETABLE_Description=Script line table
-tracing.option.LOCALE_Description=Localization
-tracing.option.LOCATIONS_Description=Source locations
-
-tracing.option.NET_Description=Net Panel
-tracing.option.NET_EVENTS_Description=Network events
-tracing.option.OPTIONS_Description=Firebug preferences
-tracing.option.PANELS_Description=Panels
-tracing.option.SHORTCUTS_Description=Keyboard shortcuts
-tracing.option.SOURCEFILES_Description=JavaScript source files
-tracing.option.SPY_Description=XMLHttpRequests observer
-tracing.option.STACK_Description=JavaScript call stack
-tracing.option.STORAGE_Description=Settings storage
-tracing.option.SVGVIEWER_Description=SVG viewer
-tracing.option.FONTS_Description=Fonts information and font viewer
-tracing.option.TOOLTIP_Description=Start Button tooltip
-tracing.option.TOPLEVEL_Description=Top level JavaScript
-tracing.option.UI_LOOP_Description=JavaScript debugging user interface
-tracing.option.WINDOWS_Description=Firebug windows & Tab Watcher
+# LOCALIZATION NOTE (Open_Firebug_Tracing, Always_Open_Firebug_Tracing):
+# Firebug tracing console menu items (located in Firebug's menu).
+Open_Firebug_Tracing=Open Firebug Tracing
+Always_Open_Firebug_Tracing=Always Open Firebug Tracing
+
+# LOCALIZATION NOTE (title.Tracing): Title for Firebug tracing console window (verb).
+title.Tracing=Tracing
+
+tracing.Show_Scope_Variables=Show Scope Variables
+tracing.Show_Time=Show Time
+tracing.tab.Stack=Stack
+tracing.tab.Exception=Exception
+tracing.tab.Properties=Properties
+tracing.tab.Scope=Scope
+tracing.tab.Response=Response
+tracing.tab.Source=Source
+tracing.tab.Interfaces=Interfaces
+tracing.tab.Object=Object
+tracing.tab.Event=Event
+tracing.cmd.Clear=Clear
+tracing.cmd.tip.Clear=Remove All Messages
+tracing.cmd.Find=Find
+tracing.cmd.tip.Find=Find Text
+tracing.cmd.Bookmark=Bookmark
+tracing.cmd.tip.Bookmark=Insert Bookmark
+tracing.cmd.Restart=Restart Firefox
+tracing.cmd.tip.Restart=Restart Firefox
+tracing.cmd.Exit=Exit Firefox
+tracing.cmd.tip.Exit=Exit Firefox
+tracing.cmd.Save=Save to File
+tracing.cmd.tip.Save=Save logs into a file
+tracing.cmd.Load=Load from File
+tracing.cmd.tip.Load=Load logs from a file
+tracing.cmd.Expand_All=Expand All
+tracing.cmd.Collapse_All=Collapse All
+tracing.cmd.Tools=Tools
+tracing.cmd.tip.Tools=Tools
+tracing.cmd.Clear_Browser_Cache=Clear Browser Cache
+tracing.cmd.tip.Clear_Browser_Cache=Clear Browser Cache
+tracing.cmd.Force_Garbage_Collector=Force Garbage Collector
+tracing.cmd.tip.Force_Garbage_Collector=Force Garbage Collector
+tracing.cmd.Open_Profile_Directory=Open Profile Directory
+tracing.cmd.tip.Open_Profile_Directory=Open Profile Directory
+tracing.option.A11Y_Description=Accessibility issues
+tracing.option.ACTIVATION_Description=Firebug activation
+tracing.option.ACTIVITYOBSERVER_Description=Firebug activity observer
+tracing.option.ANNOTATIONS_Description=Firebug website annotation
+tracing.option.BP_Description=Breakpoints
+tracing.option.CACHE_Description=Source cache
+tracing.option.COMMANDLINE_Description=Command Line & Command Line Popup
+tracing.option.COMPILATION_UNITS_Description=Script compilation units
+tracing.option.CONSOLE_Description=Console Panel
+tracing.option.CSS_Description=CSS parsing
+
+tracing.option.DISPATCH_Description=Event dispatching
+tracing.option.DOM_Description=DOM
+tracing.option.DOMPLATE_Description=Domplate creation
+tracing.option.EDITOR_Description=Inline Editor & Autocompleter
+tracing.option.ERRORLOG_Description=Error log of JS, CSS, XML etc.
+tracing.option.ERRORS_Description=Internal Firebug errors
+tracing.option.EVAL_Description=Script evaluation
+tracing.option.FBS_BP_Description=Firebug service breakpoints
+tracing.option.FBS_CREATION_Description=Firebug service script creation
+tracing.option.FBS_ERRORS_Description=Firebug service errors
+
+tracing.option.FBS_FINDDEBUGGER_Description=Firebug service find debugger
+
+tracing.option.FBS_FUNCTION_Description=Firebug service function
+tracing.option.FBS_JSDCONTEXT_Description=Firebug service JavaScript Debugger context
+tracing.option.FBS_SRCUNITS_Description=Firebug service source units
+tracing.option.FBS_STEP_Description=Firebug service JavaScript Debugger stepping
+tracing.option.FBS_TRACKFILES_Description=Firebug service tracked files
+tracing.option.FUNCTION_NAMES_Description=JavaScript function names
+tracing.option.HISTORY_Description=Firebug Navigation History
+tracing.option.HTML_Description=HTML
+tracing.option.HTTPOBSERVER_Description=HTTP request observer
+tracing.option.INFOTIP_Description=Infotip
+tracing.option.INITIALIZE_Description=Firebug initialization
+tracing.option.INSPECT_Description=Inspector
+tracing.option.JSONVIEWER_Description=JSON viewer
+tracing.option.LINETABLE_Description=Script line table
+tracing.option.LOCALE_Description=Localization
+tracing.option.LOCATIONS_Description=Source locations
+
+tracing.option.NET_Description=Net Panel
+tracing.option.NET_EVENTS_Description=Network events
+tracing.option.OPTIONS_Description=Firebug preferences
+tracing.option.PANELS_Description=Panels
+tracing.option.SHORTCUTS_Description=Keyboard shortcuts
+tracing.option.SOURCEFILES_Description=JavaScript source files
+tracing.option.SPY_Description=XMLHttpRequests observer
+tracing.option.STACK_Description=JavaScript call stack
+tracing.option.STORAGE_Description=Settings storage
+tracing.option.SVGVIEWER_Description=SVG viewer
+tracing.option.FONTS_Description=Fonts information and font viewer
+tracing.option.TOOLTIP_Description=Start Button tooltip
+tracing.option.TOPLEVEL_Description=Top level JavaScript
+tracing.option.UI_LOOP_Description=JavaScript debugging user interface
+tracing.option.WINDOWS_Description=Firebug windows & Tab Watcher
tracing.option.XMLVIEWER_Description=XML viewer
Oops, something went wrong. Retry.

0 comments on commit f109552

Please sign in to comment.