Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: firebug/firebug
...
head fork: fflorent/firebug
Checking mergeability… Don't worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 2 commit comments
  • 1 contributor
View
4 extension/content/firebug/console/commandLineInclude.js
@@ -429,6 +429,8 @@ var CommandLineInclude =
xhr.onload = function()
{
+ if (xhr.statut !== 200)
+ return errorFunction.apply(this, arguments);
var codeToEval = xhr.responseText;
Firebug.CommandLine.evaluateInWebPage(codeToEval, context);
if (successFunction)
@@ -534,7 +536,7 @@ Firebug.registerCommand("include", {
Firebug.registerRep(CommandLineIncludeRep);
-return CommandLineIncludeRep;
+return CommandLineInclude;
// ********************************************************************************************* //
}});
View
6 extension/locale/en-US/firebug.properties
@@ -775,7 +775,7 @@ commandline.include.aliasNotFound=Alias "%S" not found.
# LOCALIZATION NOTE (commandline.include.loadFail): For the include() function. This message is displayed
# in the Console panel when the remote script download failed
# %S = the filename
-commandline.include.loadFail=%S failed to load.
+commandline.include.loadFail=the following script could not be loaded: %S.
# LOCALIZATION NOTE (commandline.include.invalidRequestProtocol): For the include() function. This message is displayed
# in the Console panel when the user tries to download a script with another scheme than HTTP(S)
@@ -804,11 +804,11 @@ commandline.include.tooLongAliasName=Alias names must not contain more than 30 c
# LOCALIZATION NOTE (commandline.include.wrongAliasArgument): For the include() function. This message is displayed
# in the Console panel if the provided alias name is invalid
-commandline.include.wrongAliasArgument=Wrong alias argument; expected string.
+commandline.include.wrongAliasArgument=Wrong alias name
# LOCALIZATION NOTE (commandline.include.wrongUrlArgument): For the include() function. This message is displayed
# in the Console panel if the provided url argument is invalid
-commandline.include.wrongUrlArgument=Wrong url argument; expected string or null.
+commandline.include.wrongUrlArgument=Wrong url argument
# LOCALIZATION NOTE (commandline.include.confirmDelete): For the include() function. This message is displayed
# in a confirmation dialog when the user wants to delete an alias

Showing you all comments on commits in this comparison.

@simonlindholm

I don't think this should be an error; rather a log or something (maybe in italic, like console.log(); or console.log(""); do).

@fflorent
Owner
Something went wrong with that request. Please try again.