New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor() and debug() commands don't place breakpoints correctly #7907

Closed
fflorent opened this Issue Jun 7, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@fflorent
Member

fflorent commented Jun 7, 2015

STR:

  1. Open this page: https://www.mozilla.org/en-US/firefox/nightly/firstrun/?oldversion=38.0
  2. Enable Firebug, the Console and the Script panel
  3. Enter this command: debug(Tabzilla.open)
  4. Go to the Script panel and the "Breakpoints" side-panel

The breakpoint is actually set at the line of the function definition, not at the line of the first instruction.

Florent

@fflorent

This comment has been minimized.

Show comment
Hide comment
@fflorent

fflorent Jun 7, 2015

Member

PR created. Honza, could you review please?

Also note that I work on a similar bug for the DevTools here: https://bugzilla.mozilla.org/show_bug.cgi?id=1164880

Florent

Member

fflorent commented Jun 7, 2015

PR created. Honza, could you review please?

Also note that I work on a similar bug for the DevTools here: https://bugzilla.mozilla.org/show_bug.cgi?id=1164880

Florent

janodvarko added a commit that referenced this issue Jun 9, 2015

Merge pull request #7908 from fflorent/fix-monitor-script
#7907 monitor() and debug() commands don't place breakpoints correctly
@janodvarko

This comment has been minimized.

Show comment
Hide comment
@janodvarko

janodvarko Jun 9, 2015

Member

Merged into the master, closing.

Honza

Member

janodvarko commented Jun 9, 2015

Merged into the master, closing.

Honza

@janodvarko janodvarko closed this Jun 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment