New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit variables don't work when execution is stopped #7956

Closed
sdavidg opened this Issue Oct 14, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@sdavidg
Contributor

sdavidg commented Oct 14, 2015

It's the same problem described here: https://code.google.com/p/fbug/issues/detail?id=7550

Fb: 2.0.12
FF: 41.0.1

@fflorent

This comment has been minimized.

Show comment
Hide comment
@fflorent

fflorent Oct 14, 2015

Member

Thanks for the report David. I am working in it.

Florent

Member

fflorent commented Oct 14, 2015

Thanks for the report David. I am working in it.

Florent

@fflorent fflorent self-assigned this Oct 14, 2015

@fflorent

This comment has been minimized.

Show comment
Hide comment
@fflorent

fflorent Oct 14, 2015

Member

(technical note) : it looks like it fails to get the environments when the thread is paused, and that's the reason why we can see Object { type="object" } for the scopes. And that sounds because the associated actors can't be retrieved using threadActor._pausedActor.get(actorId) in DebuggerLib.getObject().

Tricky issue. Might be worth to bisect...

ping @janodvarko do you have any clue?

Florent

Member

fflorent commented Oct 14, 2015

(technical note) : it looks like it fails to get the environments when the thread is paused, and that's the reason why we can see Object { type="object" } for the scopes. And that sounds because the associated actors can't be retrieved using threadActor._pausedActor.get(actorId) in DebuggerLib.getObject().

Tricky issue. Might be worth to bisect...

ping @janodvarko do you have any clue?

Florent

@fflorent fflorent removed their assignment Nov 3, 2015

@sdavidg

This comment has been minimized.

Show comment
Hide comment
@sdavidg

sdavidg Nov 4, 2015

Contributor

Any advance?

Contributor

sdavidg commented Nov 4, 2015

Any advance?

@fflorent

This comment has been minimized.

Show comment
Hide comment
@fflorent

fflorent Nov 4, 2015

Member

Honza will take the bug soon.

Florent

2015-11-04 9:37 GMT+01:00 David notifications@github.com:

Any advance?


Reply to this email directly or view it on GitHub
#7956 (comment).

Member

fflorent commented Nov 4, 2015

Honza will take the bug soon.

Florent

2015-11-04 9:37 GMT+01:00 David notifications@github.com:

Any advance?


Reply to this email directly or view it on GitHub
#7956 (comment).

@janodvarko

This comment has been minimized.

Show comment
Hide comment
@janodvarko

janodvarko Nov 5, 2015

Member

Should be fixed now.

@fflorent: can you please verify?

Honza

Member

janodvarko commented Nov 5, 2015

Should be fixed now.

@fflorent: can you please verify?

Honza

@janodvarko janodvarko closed this Nov 5, 2015

@sdavidg

This comment has been minimized.

Show comment
Hide comment
@sdavidg

sdavidg Nov 5, 2015

Contributor

It works fine, thanks

Contributor

sdavidg commented Nov 5, 2015

It works fine, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment