Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixing issue 4153 #14

Merged
merged 4 commits into from Jun 21, 2012

Conversation

Projects
None yet
3 participants
Member

farshidbeheshti commented Jun 13, 2012

Issue 4153

Owner

janodvarko commented Jun 14, 2012

Works great for me!

Couple of notes:

  1. The pull requests can't be applied since your branch (issue4153) is not synced with Firebug master branch. Please update your patch.

  2. It would be great if there is more comments explaining the logic (e.g. in toggleBar and toggleDetachBar)

Thanks
Honza

janodvarko added a commit that referenced this pull request Jun 21, 2012

@janodvarko janodvarko merged commit 9a13410 into firebug:master Jun 21, 2012

Owner

janodvarko commented Jun 21, 2012

Works well, thanks!
Honza

Member

SebastianZ commented on 9796f0c Jun 21, 2012

Please avoid such inexpressive comments in the future.

Besides that thanks for the great work!

Sebastian

Member

farshidbeheshti commented Jun 21, 2012

Which one is inexpressive ? and why?

Please let me know to avoid it in the future.

Farshid Beheshti

Owner

janodvarko commented Jun 22, 2012

We are also putting the title of the issue in the commit message so, it would be:

Issue 4153: Re-attaching detached, deactivated Firebug UI doesn't close it

(the most important thing is the issue number so, we know what issue the commit belongs to)

Honza

simonlindholm added a commit to simonlindholm/firebug that referenced this pull request Feb 5, 2015

Avoid innerHTML in domplate
In the process, this ports a few domplate fixes across from firebug.next
(#14, #98).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment