fix issue #5639: Delete all watch expressions #31

Merged
merged 4 commits into from Aug 27, 2012

Conversation

Projects
None yet
2 participants
@SebastianZ

This comment has been minimized.

Show comment
Hide comment
@SebastianZ

SebastianZ Aug 27, 2012

  • The i in iDeleteWatch is a bit vexing. It should better be deleteWatchIndex.
  • Better add IDs to the items inside domPanel.js instead of checking the item.label
  • The ID for the menu entry can be deleteAllWatches.
  • The menu entry should also be shown when clicking into the empty space of the Watch side panel. In that case it should still be added above "Refresh" and you will also need to add a separator before it.

Sebastian

  • The i in iDeleteWatch is a bit vexing. It should better be deleteWatchIndex.
  • Better add IDs to the items inside domPanel.js instead of checking the item.label
  • The ID for the menu entry can be deleteAllWatches.
  • The menu entry should also be shown when clicking into the empty space of the Watch side panel. In that case it should still be added above "Refresh" and you will also need to add a separator before it.

Sebastian

@fflorent

This comment has been minimized.

Show comment
Hide comment
@fflorent

fflorent Aug 27, 2012

Member

Hi Sebastian,

I have included your remarks.
The separator between "Delete All Watches" and "Refresh" is automatically added when clicking on an empty space.

Member

fflorent commented Aug 27, 2012

Hi Sebastian,

I have included your remarks.
The separator between "Delete All Watches" and "Refresh" is automatically added when clicking on an empty space.

SebastianZ added a commit that referenced this pull request Aug 27, 2012

Merge pull request #31 from fflorent/issue5639
Now it looks great. Thanks!

Sebastian

@SebastianZ SebastianZ merged commit 49fb210 into firebug:master Aug 27, 2012

@SebastianZ

This comment has been minimized.

Show comment
Hide comment
@SebastianZ

SebastianZ Aug 27, 2012

Member

I made yet one more little improvement in eb7fe8d, which causes the option only to be shown when there are actually some watch expressions defined.

Sebastian

Member

SebastianZ commented Aug 27, 2012

I made yet one more little improvement in eb7fe8d, which causes the option only to be shown when there are actually some watch expressions defined.

Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment