#7948 Fix "href is null" appearing in the console #7951

Merged
merged 1 commit into from Oct 2, 2015

Projects

None yet

2 participants

@fflorent
Member
fflorent commented Oct 1, 2015

The backend may send a null source location in for a frame.

Because of this:
https://hg.mozilla.org/mozilla-central/annotate/9169f652fe5e69c2d77ac31929934a5bc3342e6e/devtools/server/actors/utils/TabSources.js#l276

Note: I suspect there may be other impacts when href is null. Though I can't identify them...

Florent

@fflorent fflorent #7948 Fix "href is null" appearing in the console
The backend may send a null source location in for a frame.
9531081
@fflorent

Hmm, rather !href || as otherwise, we see "null" in the call stack of console.error when running this test case:
https://jsfiddle.net/L2xacvq9/3/

Florent

@janodvarko janodvarko merged commit 1724d13 into master Oct 2, 2015
@janodvarko
Member

Looks good to me.

Honza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment