New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7948 Fix "href is null" appearing in the console #7951

Merged
merged 1 commit into from Oct 2, 2015

Conversation

Projects
None yet
2 participants
@fflorent
Member

fflorent commented Oct 1, 2015

The backend may send a null source location in for a frame.

Because of this:
https://hg.mozilla.org/mozilla-central/annotate/9169f652fe5e69c2d77ac31929934a5bc3342e6e/devtools/server/actors/utils/TabSources.js#l276

Note: I suspect there may be other impacts when href is null. Though I can't identify them...

Florent

#7948 Fix "href is null" appearing in the console
The backend may send a null source location in for a frame.
@fflorent

This comment has been minimized.

Show comment
Hide comment
@fflorent

fflorent Oct 1, 2015

Member

Hmm, rather !href || as otherwise, we see "null" in the call stack of console.error when running this test case:
https://jsfiddle.net/L2xacvq9/3/

Florent

Hmm, rather !href || as otherwise, we see "null" in the call stack of console.error when running this test case:
https://jsfiddle.net/L2xacvq9/3/

Florent

janodvarko added a commit that referenced this pull request Oct 2, 2015

Merge pull request #7951 from firebug/issue7948
 #7948 Fix "href is null" appearing in the console

@janodvarko janodvarko merged commit 1724d13 into master Oct 2, 2015

@janodvarko

This comment has been minimized.

Show comment
Hide comment
@janodvarko

janodvarko Oct 2, 2015

Member

Looks good to me.

Honza

Member

janodvarko commented Oct 2, 2015

Looks good to me.

Honza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment