Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show column label (if available) in the info bar. #91

Closed
wants to merge 1 commit into from

Conversation

wavexx
Copy link
Member

@wavexx wavexx commented Jan 31, 2015

If we have column labels, by calculating the correct column width they are often truncated. Showing the full column label in the info bar is more convenient for me.

We could in theory only show it for cases when at least one header was truncated, but in practice after playing around with it it's better to have some consistency between runs.

Similarly, if we allow to have a row index in the future, having the full-length index name there makes sense.

Note that I already proposed to show "row name,column name" in issue #61. In reality, without having the row/column numbers visible, it's harder to move around. It's more convenient to always have them visible.

Comments?

@firecat53
Copy link
Collaborator

I like it. What do you think of the format something like:

(y, x) row_label,column_label

The label can be just a - if there's no assigned label for that row or column. Also, perhaps setting a maximum width of 25% of the screen width would probably be a good idea. This could even be a fixed width highlighted box so the cell contents don't jump around so much.

@wavexx
Copy link
Member Author

wavexx commented Feb 2, 2015

On 02/01/2015 09:18 PM, Scott Hansen wrote:

I like it. What do you think of the format something like:

(y, x) row_label,column_label

The label can be just a - if there's no assigned label for that row
or column. Also, perhaps setting a maximum width of 25% of the screen
width would probably be a good idea. This could even be a fixed width
highlighted box so the cell contents don't jump around so much.

I like both proposals.

For y,x you could determine the maximal length of the number easily to
chose the optimal padding, so that labels don't jump around as well.

@firecat53 firecat53 closed this in ce189a1 Feb 3, 2015
@wavexx wavexx deleted the header_labels branch February 6, 2015 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants