rename machine package to firecracker #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmeyerhans
suggested changes
Nov 15, 2018
Contributor
nmeyerhans
left a comment
nmeyerhans
left a comment
There was a problem hiding this comment.
I believe you missed a change to cmd/firectl/main.go
Contributor
Author
|
@nmeyerhans Fixed. |
nmeyerhans
approved these changes
Nov 15, 2018
pendo324
pushed a commit
to pendo324/firecracker-go-sdk
that referenced
this pull request
Aug 27, 2024
These changes update the Response of the HTTP resolver to include the port for pulling metrics from a remote snapshotter. firecracker-microvm/firecracker-containerd#602 task firecracker-microvm#1 Signed-off-by: Gavin Inglis <giinglis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Renamed
machinepackage tofirecrackerBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.