Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upWindows diverter unassigned local variable usage #109
Comments
added a commit
that referenced
this issue
Feb 6, 2019
added a commit
that referenced
this issue
Feb 6, 2019
strictlymike
closed this
in
830e7db
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
strictlymike commentedFeb 5, 2019
FakeNet's PyDivert exception handling in
windows.py
mixes and matches local variable names for the user-friendly protocol description (protocol
vs.proto
) resulting in aUnboundLocalError
being raised due toproto
being referenced before assignment in error cases involving ICMP.The variable usage needs to be made consistent to prevent the exception.