New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates2 #108

Merged
merged 2 commits into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@strictlymike
Copy link
Contributor

strictlymike commented Jan 24, 2019

No description provided.

private fork.

All contributors:
* Pull request comment should bear bulleted list for inclusion in change log.

This comment has been minimized.

@tankbusta

tankbusta Jan 24, 2019

Member

A Pull Request should be focused on one thing like a bug fix or adding one new feature. PR's containing say 10 different bug fixes or new features should be rejected. This allows for quicker code review and not holding up say 9 fixes because 1 of them was implemented incorrectly

This comment has been minimized.

@strictlymike

strictlymike Jan 24, 2019

Author Contributor

Fair point

@strictlymike

This comment has been minimized.

Copy link
Contributor Author

strictlymike commented Jan 24, 2019

To be considered: a scheme in which versioning is handled more or less automatically using the git short hash (git log --pretty=format:'%h' -n 1). For now, keeping with old-style changelog versioning to be able to comfortably figure out whether a feature or fix is present in a given cut. Will revisit later.

@strictlymike strictlymike merged commit 011b6d4 into master Jan 24, 2019

@strictlymike strictlymike deleted the doc-updates2 branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment