Ftproot check #28
Merged
Ftproot check #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FTPListener now checks for rel/abs service root path the way HTTPListener does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By testing FakeNet-NG as configured on REMnux, I discovered that
FTPListener.pyomits a helpful check thatHTTPListener.pydoes to ensure that thedefaultFilespath can be found relative to the script file itself if an absolute path is not provided. I've copied this check from the HTTP listener and tested on Remnux. @iphelix do you want to look this over and let me know if you see any problems before merging?