Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pep8 in Travis and fix offenses #313

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@Ana06
Copy link
Contributor

commented Oct 3, 2019

pep8 was run in Travis but the result was ignored. 馃槶 In other words, the build succeeded even if there were offenses. There were some offenses as you can see in the Travis run which only includes the first commit:

https://travis-ci.org/Ana06/flare-floss/builds/593204188

I have corrected the existing offenses by running:

autopep8 -ria --ignore=E501 .
Ana06 added 2 commits Oct 3, 2019
pep8 was run in Travis but the result was ignored. In other words, the build
succeeded even if there were offenses.
Correct the existing pep8 offenses by running:

```
autopep8 -ria --ignore=E501 .
```
@mr-tz

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

Great catch! Should we take the opportunity and replace pep8 with pycodestyle, per the warning:

$ pep8 --ignore=E501 .
/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/pep8.py:2124: UserWarning: 
pep8 has been renamed to pycodestyle (GitHub issue #466)
Use of the pep8 tool will be removed in a future release.
Please install and use `pycodestyle` instead.
pep8 has been renamed to pycodestyle and will be removed in a future release.
@Ana06

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2019

@mr-tz

Should we take the opportunity and replace pep8 with pycodestyle, per the warning:

$ pep8 --ignore=E501 .
/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/pep8.py:2124: UserWarning: 
pep8 has been renamed to pycodestyle (GitHub issue #466)
Use of the pep8 tool will be removed in a future release.
Please install and use `pycodestyle` instead.

I had seen the message, but I didn't want to mix many things in the same PR. It is a small change though, so there we go: 02ae394 馃殌

@williballenthin

This comment has been minimized.

Copy link
Collaborator

commented Oct 8, 2019

lgtm, merging!

thanks @Ana06 !

@williballenthin williballenthin merged commit 5edb188 into fireeye:master Oct 8, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.