Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and optimize algorithms #14

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Fix and optimize algorithms #14

merged 3 commits into from
Jan 2, 2023

Conversation

zStupan
Copy link
Collaborator

@zStupan zStupan commented Jan 2, 2023

  • Fixed DE implementation, which was inconsistent with the pseudocode.
  • Added inbounds macros to speed up array access
  • Updated tests to cover these changes.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Base: 94.79% // Head: 99.00% // Increases project coverage by +4.21% 🎉

Coverage data is based on head (073bea9) compared to base (5a5e17f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   94.79%   99.00%   +4.21%     
==========================================
  Files          14       14              
  Lines         288      301      +13     
==========================================
+ Hits          273      298      +25     
+ Misses         15        3      -12     
Impacted Files Coverage Δ
src/optimization/de.jl 100.00% <100.00%> (+4.65%) ⬆️
src/optimization/pso.jl 100.00% <100.00%> (+2.27%) ⬆️
src/rule.jl 100.00% <0.00%> (+12.82%) ⬆️
src/feature.jl 90.90% <0.00%> (+18.18%) ⬆️
src/attribute.jl 90.90% <0.00%> (+18.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zStupan zStupan merged commit cfbc16d into firefly-cpp:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants