Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored XSS in delete link transactions. #2364

Closed
0x2500 opened this issue Aug 2, 2019 · 2 comments
Closed

Stored XSS in delete link transactions. #2364

0x2500 opened this issue Aug 2, 2019 · 2 comments
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@0x2500
Copy link

0x2500 commented Aug 2, 2019

Description
Current version of Firefly III Version 4.7.17.3 is vulnerable to stored XSS due to lack of filtration of user-supplied data in transaction description field. Malicious attacker can create specially crafted request, which contains javascript code in it. Malicious javascript code will be executed when user visit links below.

Steps to reproduce

  1. Add 2 new transactions with description "<script>alert("XSS in transaction description");</script>" and "<script>alert("XSS in transaction description 2");</script>"
  2. Link them together.
  3. Visit
/transactions/link/delete/[id of your link]

You can navigate there from transaction menu.
See 4 alerts (two first transaction description payloads, two second transaction description payloads)
POC Image
link_delete_xss

Extra info
Tested on Mozilla 60.4.0esr (64-bit)

@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Aug 2, 2019
@JC5 JC5 closed this as completed in 3ad4e04 Aug 2, 2019
@JC5
Copy link
Member

JC5 commented Aug 2, 2019

Should be fixed, if you could verify I would be grateful.

@JC5 JC5 reopened this Aug 2, 2019
@0x2500
Copy link
Author

0x2500 commented Aug 2, 2019

Fix confirmed.

@0x2500 0x2500 closed this as completed Aug 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants