Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored XSS in reports/audit. #2366

Closed
0x2500 opened this issue Aug 2, 2019 · 2 comments
Closed

Stored XSS in reports/audit. #2366

0x2500 opened this issue Aug 2, 2019 · 2 comments
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@0x2500
Copy link

0x2500 commented Aug 2, 2019

Description
Current version of Firefly III Version 4.7.17.3 is vulnerable to stored XSS due to lack of filtration of user-supplied data in asset account name. Malicious attacker can create specially crafted request, which contains javascript code in it. Malicious javascript code will be executed when user visit link below.

Steps to reproduce

  1. Add two assets accounts with names "<script>alert("account with no activity");</script>" and "<script>alert("active account");</script>".
  2. Do some activity with active account.
  3. Visit /reports/audit/[your accounts ids]/20190701/currentMonthEnd
    See 2 alerts. (one in "Account balance of (active account)" and one in "No activity was recorded on (inactive account)").
    I assume that active and inactive account XSS are different issues, due to different endpoints.
    Also, XSS fired on all endpoints /reports/audit/, where asset account name is appeared.

POC Image
report_xss

Extra info
Tested on Mozilla 60.4.0esr (64-bit)

@JC5 JC5 closed this as completed in 2ddf48f Aug 2, 2019
@JC5
Copy link
Member

JC5 commented Aug 2, 2019

Should be fixed, if you could verify I would be grateful.

@JC5 JC5 reopened this Aug 2, 2019
@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Aug 2, 2019
@0x2500
Copy link
Author

0x2500 commented Aug 2, 2019

Fixed.

@0x2500 0x2500 closed this as completed Aug 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants