Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored XSS in liability error. #2370

Closed
0x2500 opened this issue Aug 2, 2019 · 2 comments
Closed

Stored XSS in liability error. #2370

0x2500 opened this issue Aug 2, 2019 · 2 comments
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@0x2500
Copy link

0x2500 commented Aug 2, 2019

Bug description
Current version of Firefly III Version 4.7.17.5 is vulnerable to stored XSS due to lack of filtration of user-supplied data in liability name field. Malicious attacker can create specially crafted request, which contains javascript code in it. Malicious javascript code will be executed when user visit link below.

Steps to reproduce

  1. Set a new liability account with name "<script>alert("XSS in liability error")</script>" , also set "Start amount of debt" to 1, "start date of debt" to any date, "interest" to 1. Save it.
    craft_liability
  2. Go to /accounts/show/[id_of_your_liability]/all. You will see transaction with "to" and "from" fields. Grab id of account from link in "to" field. It's often id_of_your_liability + 1.
  3. Go to /accounts/delete/[id_of_your_liability], and delete liability.
  4. Now every time you visit /accounts/show/[Id which you grab before from "to" field] xss will execute.
    error_xss_liability

Extra info
Tested on Mozilla 60.4.0esr (64-bit)

@JC5 JC5 closed this as completed in 8717f46 Aug 3, 2019
@JC5
Copy link
Member

JC5 commented Aug 3, 2019

Fixed, could you confirm?

@JC5 JC5 reopened this Aug 3, 2019
@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Aug 3, 2019
@0x2500
Copy link
Author

0x2500 commented Aug 3, 2019

Bug is fixed.

@0x2500 0x2500 closed this as completed Aug 3, 2019
dm pushed a commit to dm/firefly that referenced this issue Aug 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants