From fbbadb36d8295c8e634ab34cfc73672e056c6a37 Mon Sep 17 00:00:00 2001 From: miguelgfierro Date: Thu, 28 May 2026 16:35:03 +0200 Subject: [PATCH] fix(example): software-factory pipeline imports PipelineEngine Layer 8 (#255) deleted StatePipeline but I missed the import + return type in examples/software_factory/pipeline.py. CI on #232 fails to collect tests/examples/software_factory/test_pipeline.py with: ImportError: cannot import name 'StatePipeline' from 'fireflyframework_agentic.pipeline' Fix: import PipelineEngine instead and drop the now-unnecessary cast. PipelineBuilder.build() returns PipelineEngine directly after Layer 8. Test passes locally. --- examples/software_factory/pipeline.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/examples/software_factory/pipeline.py b/examples/software_factory/pipeline.py index a686a50a..f64f3b0e 100644 --- a/examples/software_factory/pipeline.py +++ b/examples/software_factory/pipeline.py @@ -17,8 +17,6 @@ from __future__ import annotations -from typing import cast - from examples.software_factory.agents import ( architect, builder, @@ -31,7 +29,7 @@ from fireflyframework_agentic.pipeline import ( Checkpointer, PipelineBuilder, - StatePipeline, + PipelineEngine, ) @@ -40,7 +38,7 @@ def qa_router(state: BuildState) -> str: return "stable_release" if state.qa_status == "pass" else "codegen" -def build_pipeline(checkpointer: Checkpointer) -> StatePipeline: +def build_pipeline(checkpointer: Checkpointer) -> PipelineEngine: pipeline = ( PipelineBuilder( "software-factory", @@ -60,5 +58,4 @@ def build_pipeline(checkpointer: Checkpointer) -> StatePipeline: .branch("qa", qa_router) .build() ) - # state= was set, so .build() returns a StatePipeline — narrow for the type checker. - return cast("StatePipeline", pipeline) + return pipeline