[ProjectSearch] tracking issue

[jasonLaster]

We'd like to re-add the ability to search across the project.

Links

• Here's the search invision
• Here's a link to chrome's rdp method

Steps:

• add a UI for showing project search #3090
• Add a component for toggling project search between text and files #3091
• add a text search function
• Add a redux action for loading source texts #3331
• Move search functionality to redux #3342
• Refactor Project Search to support text search
• Make source search stream #3270
• Create a "search" tab #3279
• Cleanup the css and styles for dark theme #3326
• Auto focus on the first result in the list
• Highlight line where the text match was found when source file is opened #3467
• Add keyboard actions for accessibility #3501
• should scroll to keep items in focus
• File path does not appear in nightly #3782
• Improve Text Search -> Source Transition #3787
• Flow type the UI - I started here, but struggled with ManagedTree.

[clarkbw]

Pulling this image out so you don't have to jump to the doc.

[wldcordeiro]

I'd love to get hacking on this. What/where would I need to work to do these parts?

add a debugger server endpoint
add debugger client + command methods

[jasonLaster]

I'll break it down soon :) It's on the q2 roadmap!

…

On Sun, Mar 12, 2017 at 9:54 PM Wellington Cordeiro < ***@***.***> wrote: I'd love to get hacking on this. What/where would I need to work to do these parts? add a debugger server endpoint add debugger client + command methods — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1108 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPiYrAgxNrCKEP1Nojx49gTc8sGhYtHks5rlFt6gaJpZM4Kptde> .

[clarkbw]

@wanderview really wants this 😄

[jasonLaster]

I started hacking on this earlier today and made some progress

I'll post a couple PRs based on the work so that it doesn't go stale soon

• add a source search function
• Refactor Project Search to support text search
• Add a component for toggling project search between text and files
• Add a redux action for loading source texts

I started one and two and punted on three and four naturally :)

[jasonLaster]

I updated the issue description to have a good checklist

[jasonLaster]

• the results should scroll
• the selection highlight is too strong in dark theme
• we should exclude watch expressions (sources should have a URL)

[jasonLaster]

Here is a patch for styling project search:
https://gist.github.com/jasonLaster/b02fa35094cf5ef3d5055d329408aefc

[bughit]

which firefox version is this planned for?

[jasonLaster]

It's turned on nightly today :)

[jasonLaster]

going to close this as we have done the big items and shipped!