Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QuickOpen] Style selected matches  #5679

Closed
jasonLaster opened this issue Mar 15, 2018 · 8 comments

Comments

@jasonLaster
Copy link
Contributor

@jasonLaster jasonLaster commented Mar 15, 2018

We currently do a bad job of styling the black fuzzy matches when a row is selected.

@humphd

This comment has been minimized.

Copy link

@humphd humphd commented Mar 16, 2018

@jasonLaster my students are picking bugs to work on right now, and @AlexWang-16 is wondering about this one. Would you suggest this as a good-first-bug for him, or do you have another suggestion that might be better? Thanks for any advice.

@jasonLaster

This comment has been minimized.

Copy link
Contributor Author

@jasonLaster jasonLaster commented Mar 16, 2018

Yep, this would be great

@darkwing @violasong do you have an idea of what this should look like?

@jasonLaster

This comment has been minimized.

Copy link
Contributor Author

@jasonLaster jasonLaster commented Mar 16, 2018

@humphd join our slack so we can discuss other issues + projects https://devtools-html-slack.herokuapp.com/

@violasong

This comment has been minimized.

Copy link
Member

@violasong violasong commented Mar 16, 2018

I think fuzzy matches can be white bold when selected - it's a subtle look but same as what we do in the Firefox URL bar.

@AlexWang-16

This comment has been minimized.

Copy link
Contributor

@AlexWang-16 AlexWang-16 commented Mar 16, 2018

Thanks for the confirmation @jasonLaster. I'm happy to take a stab at this bug. I've also joined slack for Firefox Nightly. I did not see a channel for devtools-html. Should I join devtools-core instead?

@jasonLaster

This comment has been minimized.

Copy link
Contributor Author

@jasonLaster jasonLaster commented Mar 17, 2018

hmm - there should be a #general and #debugger room

@jasonLaster

This comment has been minimized.

Copy link
Contributor Author

@jasonLaster jasonLaster commented Mar 21, 2018

Hey @AlexWang-16 how's it going?

@AlexWang-16

This comment has been minimized.

Copy link
Contributor

@AlexWang-16 AlexWang-16 commented Mar 22, 2018

@jasonLaster I think I got it. Going to finalize everything then do a PR. It should be ready within 10 - 15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.