Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Column Breakpoints #7241

Open
darkwing opened this issue Nov 6, 2018 · 2 comments

Comments

@darkwing
Copy link
Contributor

commented Nov 6, 2018

Supersedes #7028.

Server-side Meta Bug.

Column breakpoints are currently flagged as devtools.debugger.features.column-breakpoints. Once we turn them on, there are a number of tasks remaining:

MVP

  • Update the marker logic to only display if the column breakpoint location is within the viewport.
  • Performance: Switching between tabs is painfully slow when column breakpoints are enabled.
  • Disable column breakpoints for pretty printed files and original sources with line breakpoints (#7248)

Polish

  • When clicking on the line in the gutter to add a breakpoint, add the breakpoint to the first possible column, not just 0 or undefined (Status: PR: #7392)
  • Ensure that the breakpoint symbol on the editor line isn't removed when a column breakpoint is deactivated, unless the only activated column breakpoint is removed. (Status: PR: #7410)
  • Add a context menu to column breakpoints (Status: Experiment: https://github.com/darkwing/debugger.html/tree/experiment-column-context)
  • Ensure that jumping to a pause location still scrolls to the right location. (Status: None)
  • Implement new UI
  • Memoize getCallSites (Status: None; Bug: #7309)
  • Enrich the gutter and breakpoint menus to include "Disable all on line", "Enable all on line", "Remove all on line" (Status: None)

Todos

  • add server integration for breakable positions
  • Review how breakpoint sync behaves as files with column breakpoints change to make sure that still works well
  • should be able to preview
  • enable column breakpoints for the tests
  • enable column breakpoints
  • update selected location support #8025
  • load breakpoint positions when a source is loaded
  • finish column bps test pr
  • review Critical Path Interactions
  • Resolve onSources exception: #8106
  • Breakpoints in HTML files with more than one <script> are broken: bugzilla 1535246

Polish

  • Generated breakpoint position does not correspond with original Bugzilla #1533571
  • Unexpectedly getting the second breakpoint enabled on line #8092
  • Column breakpoints seem to spring into existance when you stop scrolling #8089
  • Can't add a breakpoint in increment bundle.js:106:51
  • Implement new colors #7332
  • Shift-clicking line-breakpoint does not toggle all enabled column breakpoints #8105
@jasonLaster

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

@darkwing i think the preview thing might have been fixed :)

@digitarald

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Checked off Critical Path Interactions and found one bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.