Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Sources] Improve design of thread group headers #8128

Closed
fvsch opened this issue Mar 15, 2019 · 5 comments
Closed

[Sources] Improve design of thread group headers #8128

fvsch opened this issue Mar 15, 2019 · 5 comments
Labels

Comments

@fvsch
Copy link
Contributor

fvsch commented Mar 15, 2019

It looks like in some situations we are grouping sources under "Main thread", "Workers", etc.

The UI for those group headers looks a bit raw:

  • It adds a bit too much space at the top (we would like to keep items starting at 4px from the top edge).
  • Not sure those headers have the same height as other items.
  • Horizontal text alignment is a bit off.
  • Most importantly, they don't come off as headers. Maybe we should make them bold or find some other way to make sure the grouping is obvious to users.

@jasonLaster do you know:

@claim claim bot added the not-available label Mar 15, 2019
@fvsch
Copy link
Contributor Author

fvsch commented Mar 18, 2019

Current style:

debugger-sources-thread-header-current

Accordion style:

debugger-sources-thread-header-accordion

Maybe we should just go and use the accordion component, making each group collapsible?

Minimal style:

debugger-sources-thread-header-minimal

@abhiaecs
Copy link

Hey!
Is this bug already claimed? Or can you assign it to me?

@fvsch
Copy link
Contributor Author

fvsch commented Mar 27, 2019

We might need to decide on the design first.

@jasonLaster I remember you said on Slack that you wanted to have a single tree with the threads/workers as the first level nodes?

@jasonLaster
Copy link
Contributor

yep - i was planning on a single tree.

@fvsch
Copy link
Contributor Author

fvsch commented Jul 19, 2019

Fixed by Jason in 69 I believe.

@fvsch fvsch closed this as completed Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants