Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Align Text Vertically in Watch Expressions Panel Section #2142

Merged
merged 1 commit into from
Feb 25, 2017

Conversation

zystvan
Copy link
Contributor

@zystvan zystvan commented Feb 24, 2017

Associated Issue: #2123

Summary of Changes

  • Vertically align the text inside the Watch Expressions section in the panel
  • Make the Watch Expressions section the same height as other sections by default

Test Plan

  • It looks correct
  • Devtools says that the section is the correct height
  • Devtools shows that the text is centered

Screenshots/Videos

Screenshot of side panel

@jasonLaster
Copy link
Contributor

Thanks @zystvan this looks great

@codecov-io
Copy link

codecov-io commented Feb 25, 2017

Codecov Report

Merging #2142 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2142   +/-   ##
======================================
  Coverage       0%      0%           
======================================
  Files          74      73    -1     
  Lines        2306    2290   -16     
======================================
+ Misses       2306    2290   -16
Impacted Files Coverage Δ
src/components/Editor/Tabs.js 0% <ø> (ø)
src/components/Editor/SearchBar.js 0% <ø> (ø)
src/utils/parser.js 0% <ø> (ø)
src/utils/utils.js 0% <ø> (ø)
src/components/SecondaryPanes/Scopes.js 0% <ø> (ø)
src/utils/object-inspector.js 0% <ø> (ø)
src/components/shared/ObjectInspector.js 0% <ø> (ø)
src/components/Editor/index.js 0% <ø> (ø)
src/components/shared/Popover.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ad9a8...25826cf. Read the comment docs.

@jasonLaster jasonLaster merged commit 5c7d4ec into firefox-devtools:master Feb 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants