Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Text Vertically in Watch Expressions Panel Section #2142

Merged
merged 1 commit into from Feb 25, 2017

Conversation

Projects
None yet
3 participants
@zystvan
Copy link
Contributor

zystvan commented Feb 24, 2017

Associated Issue: #2123

Summary of Changes

  • Vertically align the text inside the Watch Expressions section in the panel
  • Make the Watch Expressions section the same height as other sections by default

Test Plan

  • It looks correct
  • Devtools says that the section is the correct height
  • Devtools shows that the text is centered

Screenshots/Videos

Screenshot of side panel

@jasonLaster

This comment has been minimized.

Copy link
Contributor

jasonLaster commented Feb 24, 2017

Thanks @zystvan this looks great

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 25, 2017

Codecov Report

Merging #2142 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2142   +/-   ##
======================================
  Coverage       0%      0%           
======================================
  Files          74      73    -1     
  Lines        2306    2290   -16     
======================================
+ Misses       2306    2290   -16
Impacted Files Coverage Δ
src/components/Editor/Tabs.js 0% <ø> (ø)
src/components/Editor/SearchBar.js 0% <ø> (ø)
src/utils/parser.js 0% <ø> (ø)
src/utils/utils.js 0% <ø> (ø)
src/components/SecondaryPanes/Scopes.js 0% <ø> (ø)
src/utils/object-inspector.js 0% <ø> (ø)
src/components/shared/ObjectInspector.js 0% <ø> (ø)
src/components/Editor/index.js 0% <ø> (ø)
src/components/shared/Popover.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ad9a8...25826cf. Read the comment docs.

@jasonLaster jasonLaster merged commit 5c7d4ec into firefox-devtools:master Feb 25, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 52ad9a8...25826cf
Details
codecov/project 0% remains the same compared to 52ad9a8
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.