Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tab Dropdown in RTL Mode #2222

Merged
merged 1 commit into from Mar 1, 2017

Conversation

Projects
None yet
3 participants
@zystvan
Copy link
Contributor

zystvan commented Feb 28, 2017

Associated Issue: #2075

Summary of Changes

  • Make the tab-overflow dropdown visible in RTL mode.

Test Plan

  • Looks right
  • Is the same position as original code gave before being passed through postcss-bidirection

Screenshots/Videos

LTR RTL
screenshot from 2017-02-28 16-24-55 screenshot from 2017-02-28 16-20-23
@jasonLaster

This comment has been minimized.

Copy link
Contributor

jasonLaster commented Feb 28, 2017

looks good. I'll test in a bit

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 28, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@3bef96a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #2222   +/-   ##
========================================
  Coverage          ?      0%           
========================================
  Files             ?      73           
  Lines             ?    2290           
  Branches          ?       0           
========================================
  Hits              ?       0           
  Misses            ?    2290           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bef96a...9fa66d2. Read the comment docs.

@jasonLaster jasonLaster force-pushed the zystvan:rtl_dropdown branch from 335f1df to 9fa66d2 Mar 1, 2017

@jasonLaster jasonLaster merged commit 18b9ad1 into firefox-devtools:master Mar 1, 2017

1 check was pending

ci/circleci CircleCI is running your tests
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.