Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Fix Tab Dropdown in RTL Mode - #2222

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
zystvan:rtl_dropdown
Mar 1, 2017
Merged

jasonLaster merged 1 commit into
firefox-devtools:masterfrom
zystvan:rtl_dropdown

Conversation

@zystvan

@zystvan zystvan commented Feb 28, 2017 •

Copy link
Copy Markdown
Contributor

Associated Issue: #2075

Summary of Changes

  • Make the tab-overflow dropdown visible in RTL mode.

Test Plan

  • Looks right
  • Is the same position as original code gave before being passed through postcss-bidirection

Screenshots/Videos

LTR RTL
screenshot from 2017-02-28 16-24-55 screenshot from 2017-02-28 16-20-23

@jasonLaster

Copy link
Copy Markdown
Contributor

looks good. I'll test in a bit

@codecov-io

codecov-io commented Feb 28, 2017 •

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@3bef96a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #2222   +/-   ##
========================================
  Coverage          ?      0%           
========================================
  Files             ?      73           
  Lines             ?    2290           
  Branches          ?       0           
========================================
  Hits              ?       0           
  Misses            ?    2290           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bef96a...9fa66d2. Read the comment docs.

@jasonLaster
jasonLaster merged commit 18b9ad1 into firefox-devtools:master Mar 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants