Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open quick open without prefix selected #5715

Merged

Conversation

@MarkPollmann
Copy link
Contributor

MarkPollmann commented Mar 19, 2018

Fixes Issue: #5710

Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests

Summary of Changes

  • set the hasPrefix prop of the SearchInput component to true
  • update jest snapshots

Test Plan

Tell us a little a bit about how you tested your patch.

Example test plan:

  • Command-Shift-O opens the panel
  • Check that the prefix (@) is not selected
  • Start typing without deletion of the prefix

Here's the Debugger's Testing doc
https://docs.google.com/document/d/1oBMRxV8A2ag2t22YsQOxTdEv0mXKzIg0tggJjRkU1S0/edit#.
Feel free to improve it!

Screenshots/Videos (OPTIONAL)

unselected-prefix

Copy link
Contributor

darkwing left a comment

Nice work @MarkPollmann !!

@darkwing darkwing merged commit cb8ed00 into firefox-devtools:master Mar 19, 2018
4 checks passed
4 checks passed
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.