This repository has been archived by the owner. It is now read-only.
[sources] improve updateSource performance #6856
Merged
Conversation
| const existingUrls = state.urls[source.url]; | ||
| const urls = existingUrls ? [...existingUrls, source.id] : [source.id]; | ||
| state.urls[source.url] = existingUrls |
darkwing
Aug 21, 2018
Contributor
Do we need to take into account origin vs. generated here? Since a sourcemap can have the same URL?
Do we need to take into account origin vs. generated here? Since a sourcemap can have the same URL?
jasonLaster
added a commit
that referenced
this pull request
Aug 22, 2018
jasonLaster
added a commit
that referenced
this pull request
Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Issue: #6829
Summary of Changes
old
https://perfht.ml/2OUOQKH
new
https://perfht.ml/2OVCMsz
now the time spent is almost entirely in the UI which is the bigger blips next to the longer bars in the old perf graph