This repository has been archived by the owner. It is now read-only.
Use renderStacktrace prop if provided to render Error rep stacktrace #7140
Conversation
|
I don't think we want the change to |
This will allow us to use the same component in the console and in reps for example. If the prop is not passed, it defers to the current stacktrace rendering.
nchevobbe
force-pushed the
nchevobbe:error-rep-render-stacktrace
branch
from
e4fbd5a
to
eb3bfc0
good catch! |
|
@janodvarko Just a heads up you were requested for review here |
|
Looks good to me, thanks Nicolas! Honza |
| @@ -20,7 +20,8 @@ const IGNORED_SOURCE_URLS = ["debugger eval code"]; | |||
| ErrorRep.propTypes = { | |||
| object: PropTypes.object.isRequired, | |||
| // @TODO Change this to Object.values when supported in Node's version of V8 | |||
| mode: PropTypes.oneOf(Object.keys(MODE).map(key => MODE[key])) | |||
| mode: PropTypes.oneOf(Object.keys(MODE).map(key => MODE[key])), | |||
| renderStacktrace: PropTypes.func | |||
janodvarko
Oct 25, 2018
Member
It would be great to have an explanatory comment for the new prop
renderStacktrace: PropTypes.func
It would be great to have an explanatory comment for the new prop
renderStacktrace: PropTypes.func
nchevobbe
Oct 25, 2018
Author
Member
done ✅
done
darkwing
added a commit
that referenced
this pull request
Oct 25, 2018
…7140) * Use renderStacktrace prop if provided to render Error rep stacktrace This will allow us to use the same component in the console and in reps for example. If the prop is not passed, it defers to the current stacktrace rendering. * Update error.js
darkwing
added a commit
that referenced
this pull request
Oct 26, 2018
…7140) * Use renderStacktrace prop if provided to render Error rep stacktrace This will allow us to use the same component in the console and in reps for example. If the prop is not passed, it defers to the current stacktrace rendering. * Update error.js
darkwing
added a commit
that referenced
this pull request
Oct 26, 2018
…7140) * Use renderStacktrace prop if provided to render Error rep stacktrace This will allow us to use the same component in the console and in reps for example. If the prop is not passed, it defers to the current stacktrace rendering. * Update error.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This will allow us to use the same component
in the console and in reps for example.
If the prop is not passed, it defers to the
current stacktrace rendering.
Fixes #7130