Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Consolidate icon styles into AccessibleImage.css and SourceIcon.css #7890
Summary of Changes
I know there is a LOT in that pull request, but I don't think there would be much value in trying to break it up in half a dozen PRs. The changes are all somewhat related to deduplicating image styles and making sure images are 16x16 99% of the time and look good with the accompanying content. JS changes are limited to changing classes, icon names, and exceptionally moving an element outside of its parent and into its grandparent container.
The best way to test this PR would be to check it out and take it for a ride, paying extra attention to icons in Sources and in search UIs.
Checked the following components for any major regressions, and couldn't find much apart from the minor ones I list below. Really great job on this - thanks @fvsch!!!
I only ran into a few things:
@darkwing In Firefox 66 we updated the Plus and Close icons in mozilla-central (so for all the other DevTools panels) to use the Photon icons, which look bigger with their 2px strokes.
That being said, your screenshots look strange to me because the Plus icon should be fatter, and the Close icon should be a tad slimmer. Could it be a browser cache issue? I'll check on my side too.