Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deploy-preview] Add event delay track for each thread #2282

Open
wants to merge 3 commits into
base: master
from

Conversation

@canova
Copy link
Member

canova commented Oct 18, 2019

This is a deploy preview for jesup's work on gecko side. It adds deploy event delay tracks for each thread.

Deploy preview

@canova

This comment has been minimized.

Copy link
Member Author

canova commented Oct 18, 2019

cc @jesup

@canova canova force-pushed the canova:event-delay-measurements branch 2 times, most recently from 5eb545b to 9ab145e Oct 18, 2019
@gregtatum

This comment has been minimized.

Copy link
Member

gregtatum commented Nov 6, 2019

I may be missing some context here, but I figured I would leave some comments and feedback here.

  1. I don't really understand the graph shape here. Especially how the number shoots up all of a sudden.

  2. Is this going to be an off by default feature? It's a pretty big amount of UI screen real-estate to take up. I would advocate against adding it for everyone unless they opt in to it.

  3. A small comment, but the graph should probably use the same red as the existing responsiveness markers. Orange is for memory.

@gregtatum gregtatum closed this Nov 6, 2019
@julienw

This comment has been minimized.

Copy link
Contributor

julienw commented Nov 7, 2019

Was the close a mistake @gregtatum ? :)

@gregtatum gregtatum reopened this Nov 7, 2019
canova added 3 commits Oct 18, 2019
@canova canova force-pushed the canova:event-delay-measurements branch from e3e79b3 to 36d95a6 Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.