Add page information for JS frames and display it inside JS tooltips#2300
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2300 +/- ##
=========================================
- Coverage 86.11% 86.1% -0.02%
=========================================
Files 204 204
Lines 15019 15054 +35
Branches 3769 3774 +5
=========================================
+ Hits 12934 12962 +28
- Misses 1913 1918 +5
- Partials 172 174 +2
Continue to review full report at Codecov.
|
gregtatum
left a comment
gregtatum
left a comment
There was a problem hiding this comment.
I didn't finish the review yet (I forgot to send what I had so far on Friday), but here are some comments so far. In the future it would be nicer to break up the upgrading code into a separate commit. It's quite hard to review that code, with all of the other component changes and snapshot changes as well.
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
@gregtatum sorry about the single huge commit. I should have split those upgraders. Will do in the future. Addressed your comments and answered some of them.
canova
force-pushed
the
frame-page-info
branch
from
3033361 to
21b6814
Compare
gregtatum
left a comment
gregtatum
left a comment
There was a problem hiding this comment.
Thanks! This is looking good to me now. The only thing I noticed was some missing test coverage, which I marked as optional and possibly a follow-up, so we could land now since this is a big PR already.
| // Finding current frame and parent frame URL(if there is). | ||
| let pageAndParentPageURL; | ||
| if (pages) { | ||
| const page = pages.find(p => p.innerWindowID === innerWindowID); |
There was a problem hiding this comment.
Optional, or follow-up: I noticed in the codecov report that this area wasn't covered by a test. It'd be good to snapshot test, and maybe use getByText to find the URLs in the component.
There was a problem hiding this comment.
Adding tests for this, but probably it would be good to review those tests. Will open a follow-up PR for that.
2 participants
This is the front-end of Bug 1468789. Adds upgraders for the new frameTable field and displays that information in the JS tooltips.
Example profile
Example tooltip of JS frame that belongs to an iframe:
