Add symbolication status to the meta info, plus a button to re-symbolicate #2448
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2448 +/- ##
==========================================
- Coverage 86.76% 86.73% -0.03%
==========================================
Files 211 211
Lines 16131 16152 +21
Branches 4080 4090 +10
==========================================
+ Hits 13996 14010 +14
- Misses 1943 1950 +7
Partials 192 192
Continue to review full report at Codecov.
|
|
Looks great to me, thanks for the quick fix! |
| onClick={resymbolicateProfile} | ||
| type="button" | ||
| className="photon-button photon-button-micro" | ||
| > |
canova
Mar 11, 2020
Member
I was a bit hesitant about the button size, but tried the other options like 100% width or 100% of the right section. They didn't look better 🤷♂
I was a bit hesitant about the button size, but tried the other options like 100% width or 100% of the right section. They didn't look better
| expect(getByText('Attempting to re-symbolicate profile')).toBeTruthy(); | ||
| // No symbolicate button is available. | ||
| expect(queryByText('Symbolicate profile')).toBeFalsy(); | ||
| expect(queryByText('Re-symbolicate profile')).toBeFalsy(); |
canova
Mar 11, 2020
Member
nice tests!
nice tests!
gregtatum
merged commit d66e9f4
into
firefox-devtools:master
9 of 11 checks passed
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Example profile:
https://deploy-preview-2448--perf-html.netlify.com/public/6a5142c47da73320ff5491488996c2948207cae9/calltree/?globalTrackOrder=0-1-2-3-4-5&localTrackOrderByPid=5620-1-2-0~3824-1-0~7960-1-0~2932-1-0~6316-1-0~10324-1-2-0~&thread=1&timelineType=stack&v=4
This introduces a lot of warnings about unhandled promise rejections in the tests. These are fixed in #2447.