Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IPC message tooltip labels to be more descriptive #2616

Merged
merged 1 commit into from Jul 4, 2020

Conversation

@jimporter
Copy link
Contributor

@jimporter jimporter commented Jun 30, 2020

This provides more descriptive labels for durations in IPC messages:

  • IPC Speed -> IPC Send Duration
  • IPC Latency -> IPC Recv Latency

I forgot to make these changes in #2535 after some feedback from Markus about the naming. This fixes the naming to be consistent with the text in the docs (which I did remember to update).

@jimporter jimporter requested a review from gregtatum Jun 30, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 30, 2020

Codecov Report

Merging #2616 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2616   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files         218      218           
  Lines       17377    17377           
  Branches     4512     4509    -3     
=======================================
  Hits        15016    15016           
  Misses       2162     2162           
  Partials      199      199           
Impacted Files Coverage Δ
src/components/tooltip/Marker.js 87.28% <ø> (ø)
src/components/app/MenuButtons/MetaInfo.js 85.71% <100.00%> (ø)
src/profile-logic/profile-metainfo.js 88.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9cfc7...f115d74. Read the comment docs.

@julienw julienw closed this Jul 1, 2020
@julienw julienw reopened this Jul 1, 2020
Copy link
Member

@gregtatum gregtatum left a comment

Looks good to me!

@jimporter jimporter force-pushed the jimporter:ipc-rename branch from 63d3924 to 3abf287 Jul 4, 2020
This provides more descriptive labels for durations in IPC messages:
* IPC Speed -> IPC Send Duration
* IPC Latency -> IPC Recv Latency
@jimporter jimporter force-pushed the jimporter:ipc-rename branch from 3abf287 to f115d74 Jul 4, 2020
@jimporter jimporter merged commit 6a61d55 into firefox-devtools:main Jul 4, 2020
11 checks passed
11 checks passed
ci/circleci: alex Your tests passed on CircleCI!
Details
ci/circleci: build-prod Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: licence-check Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
ci/circleci: yarn_lock Your tests passed on CircleCI!
Details
@codecov
codecov/patch 100.00% of diff hit (target 86.41%)
Details
@codecov
codecov/project 86.41% (+0.00%) compared to b0251a7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details
@jimporter jimporter deleted the jimporter:ipc-rename branch Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants