Use appropriate time unit in markers chart #2628
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2628 +/- ##
==========================================
+ Coverage 86.41% 86.44% +0.02%
==========================================
Files 218 218
Lines 17377 17377
Branches 4512 4512
==========================================
+ Hits 15016 15021 +5
+ Misses 2162 2158 -4
+ Partials 199 198 -1
Continue to review full report at Codecov.
|
src/components/tooltip/Marker.js
Outdated
| @@ -811,7 +812,7 @@ class MarkerTooltipContents extends React.PureComponent<Props> { | |||
| {/* we don't know the duration if the marker is incomplete */} | |||
| {!marker.incomplete | |||
| ? marker.dur | |||
| ? formatMilliseconds(marker.dur) | |||
| ? formatTimestamp(marker.dur) | |||
julienw
Jul 6, 2020
Contributor
Thanks!
I think we should make it slightly less precise by adding some parameters to the call.
What about using 3, 1? (means 3 significant digits, 1 fractional digit max)
Thanks!
I think we should make it slightly less precise by adding some parameters to the call.
What about using 3, 1? (means 3 significant digits, 1 fractional digit max)
ajhpark
Jul 6, 2020
Author
Contributor
Done
Done
|
This looks better to me. I'd like a double check from @padenot who filed the issue at first before landing, but this should be good. |
julienw
merged commit def6d62
into
firefox-devtools:main
8 of 9 checks passed
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Use new formatTimestamp function and update snapshots.
Fixes #2619