New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FireQOS DSCP matching produces wrong tc command #248

Closed
mikenor opened this Issue Aug 8, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@mikenor

mikenor commented Aug 8, 2017

I'm attempting to use DSCP matching in FireQOS 3.1.3. When I run debug mode to observe the tc commands, I see that FireQOS specifies the TOS value incorrectly.

For example, I have a class where I am doing match dscp AF31. The resulting tc command that FireQOS uses is: tc filter add dev eth2 parent 1:0 protocol ip prio 30 u32 match ip tos 0x68 0x68 flowid 1:13.

In particular, it seems the mask parameter given to tc is incorrect. When I run FireQOS in status mode, I see that packets with AF33 are being matched by this class, which is wrong.

A TOS value is an 8-bit number, but only the first 6 bits are the DSCP value. So the mask parameter given to tc should look at the first 6 bits and ignore the last 2 bits. Which I guess should be 0xfc.

@mikenor

This comment has been minimized.

Show comment
Hide comment
@mikenor

mikenor Aug 8, 2017

As a workaround, I tried configuring my class using match tos 0x68/0xfc instead of match dscp AF31. When I attempt this, the resulting tc command looks correct, but then when I run FireQOS status mode the entire utilization table just shows "ERROR" for all values. :-(

mikenor commented Aug 8, 2017

As a workaround, I tried configuring my class using match tos 0x68/0xfc instead of match dscp AF31. When I attempt this, the resulting tc command looks correct, but then when I run FireQOS status mode the entire utilization table just shows "ERROR" for all values. :-(

ktsaou added a commit to ktsaou/firehol that referenced this issue Aug 16, 2017

@ktsaou

This comment has been minimized.

Show comment
Hide comment
@ktsaou

ktsaou Aug 16, 2017

Member

Thanks for reporting it.
Committed a patch to fix it.

Member

ktsaou commented Aug 16, 2017

Thanks for reporting it.
Committed a patch to fix it.

@ktsaou ktsaou referenced this issue Aug 16, 2017

Merged

Fix FireQoS bugs #251

@ktsaou ktsaou closed this in #251 Aug 18, 2017

@ktsaou

This comment has been minimized.

Show comment
Hide comment
@ktsaou

ktsaou Aug 18, 2017

Member

merged it.
Thank you for reporting it!

Member

ktsaou commented Aug 18, 2017

merged it.
Thank you for reporting it!

philwhineray added a commit that referenced this issue Aug 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment